- Notifications
You must be signed in to change notification settings - Fork4.9k
Commite4b0f86
committed
pg_dump: Fix incorrect archive format shown in error message.
In pg_dump and pg_restore, _allocAH() calls _discoverArchiveFormat() todetermine the archive format when the input format is unknown one.If the input or discovered format is unrecognized, it reports an errorincluding the archive format number.If discovered format is unrecognized, its number should be shown inthe error message. But previously the error message mistakenly showedthe originally requested format number (i.e., unknown one) instead ofthe discovered one, due to referencing the wrong variable in the errormessage.This commit corrects the issue by using the appropriate variable inthe error message.This fix has no practical impact since _discoverArchiveFormat() neverreturns an unrecognized format and that error mesasge is actuallynever output. Therefore, while the issue exists in back branches,it's not worth the trouble and buildfarm cycles to back-patch.So this fix is applied only to the master branch.Author: Mahendra Singh Thalor <mahi6run@gmail.com>Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Reviewed-by: Fujii Masao <masao.fujii@gmail.com>Discussion:https://postgr.es/m/CAKYtNAqu+N-Ab2Fq6wzNSOm_-0N-BMneanYNV1+6kFDXjva1Eg@mail.gmail.com1 parent2e5353b commite4b0f86
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2469 | 2469 | | |
2470 | 2470 | | |
2471 | 2471 | | |
2472 | | - | |
| 2472 | + | |
2473 | 2473 | | |
2474 | 2474 | | |
2475 | 2475 | | |
| |||
0 commit comments
Comments
(0)