NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commite3cc039

committed

Skip second WriteToc() call for custom-format dumps without data.

Presently, "pg_dump --format=custom" calls WriteToc() twice. Thesecond call updates the data offset information, which allegedlymakes parallel pg_restore significantly faster. However, if we'renot dumping any data, there are no data offsets to update, so wecan skip this step.Reviewed-by: Jeff Davis <pgsql@j-davis.com>Discussion:https://postgr.es/m/Z9c1rbzZegYQTOQE%40nathan

1 parentd9c7911 commite3cc039Copy full SHA for e3cc039

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_backup_custom.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_backup_custom.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -755,9 +755,11 @@ _CloseArchive(ArchiveHandle *AH)`
`755`	`755`	`* If possible, re-write the TOC in order to update the data offset`
`756`	`756`	`* information. This is not essential, as pg_restore can cope in most`
`757`	`757`	`* cases without it; but it can make pg_restore significantly faster`
`758`		`- * in some situations (especially parallel restore).`
	`758`	`+ * in some situations (especially parallel restore). We can skip this`
	`759`	`+ * step if we're not dumping any data; there are no offsets to update`
	`760`	`+ * in that case.`
`759`	`761`	`*/`
`760`		`-if (ctx->hasSeek&&`
	`762`	`+if (ctx->hasSeek&&AH->public.dopt->dumpData&&`
`761`	`763`	`fseeko(AH->FH,tpos,SEEK_SET)==0)`
`762`	`764`	`WriteToc(AH);`
`763`	`765`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite3cc039

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_backup_custom.c`

0 commit comments