NotificationsYou must be signed in to change notification settings
Fork5k
Star17.9k

Commite35ff65

committed

Fix potential integer overflow in bringetbitmap()

This function expects an "int64" as result and stores the number ofpages to add to the index scan bitmap as an "int", multiplying its finalresult by 10. For a relation large enough, this can theoreticallyoverflow if counting more than (INT32_MAX / 10) pages, knowing that thenumber of pages is upper-bounded by MaxBlockNumber.To avoid the overflow, this commit redefines "totalpages", used tocalculate the result, to be an "int64" rather than an "int".Reported-by: Evgeniy GorbanyovAuthor: James HunterDiscussion:https://www.postgresql.org/message-id/07704817-6fa0-460c-b1cf-cd18f7647041@basealt.ruBackpatch-through: 13

1 parent9e596a0 commite35ff65Copy full SHA for e35ff65

File tree

1 file changed

-1

lines changed

src/backend/access/brin
- brin.c

1 file changed

-1

lines changed

`‎src/backend/access/brin/brin.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm)`
`361`	`361`	`BrinOpaque*opaque;`
`362`	`362`	`BlockNumbernblocks;`
`363`	`363`	`BlockNumberheapBlk;`
`364`		`-inttotalpages=0;`
	`364`	`+int64totalpages=0;`
`365`	`365`	`FmgrInfo*consistentFn;`
`366`	`366`	`MemoryContextoldcxt;`
`367`	`367`	`MemoryContextperRangeCxt;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite35ff65

File tree

1 file changed

1 file changed

`‎src/backend/access/brin/brin.c`

0 commit comments