NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitde0bea8

committed

Lock relation used to generate fresh data for RMV.

Back-patch the 9.4-era commit2636ecf into 9.3, as that fixes a casewhere we open a relation while not holding any lock on it. It'sprobably mostly safe anyway, since no other session could touch thenewly-created table; but I think CheckTableNotInUse could be fooledif one tried.Per testing with a patch that complains if we open a relation withoutholding any lock on it. I don't plan to back-patch that patch, but weshould close the holes it identifies in all supported branches.Discussion:https://postgr.es/m/2038.1538335244@sss.pgh.pa.us

1 parent00d00b5 commitde0bea8Copy full SHA for de0bea8

File tree

1 file changed

-1

lines changed

src/backend/commands
- matview.c

1 file changed

-1

lines changed

`‎src/backend/commands/matview.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@`
`26`	`26`	`#include"executor/executor.h"`
`27`	`27`	`#include"miscadmin.h"`
`28`	`28`	`#include"rewrite/rewriteHandler.h"`
	`29`	`+#include"storage/lmgr.h"`
`29`	`30`	`#include"storage/smgr.h"`
`30`	`31`	`#include"tcop/tcopprot.h"`
`31`	`32`	`#include"utils/rel.h"`
`@@ -208,8 +209,13 @@ ExecRefreshMatView(RefreshMatViewStmt stmt, const char queryString,`
`208`	`209`
`209`	`210`	`tableSpace=matviewRel->rd_rel->reltablespace;`
`210`	`211`
`211`		`-/* Create the transient table that will receive the regenerated data. */`
	`212`	`+/*`
	`213`	`+ * Create the transient table that will receive the regenerated data. Lock`
	`214`	`+ * it against access by any other process until commit (by which time it`
	`215`	`+ * will be gone).`
	`216`	`+ */`
`212`	`217`	`OIDNewHeap=make_new_heap(matviewOid,tableSpace);`
	`218`	`+LockRelationOid(OIDNewHeap,AccessExclusiveLock);`
`213`	`219`	`dest=CreateTransientRelDestReceiver(OIDNewHeap);`
`214`	`220`
`215`	`221`	`/* Generate the data, if wanted. */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitde0bea8

File tree

1 file changed

1 file changed

`‎src/backend/commands/matview.c`

0 commit comments