Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitdcd4454

Browse files
committed
Remove unnecessary dependencies to wal_level=logical in TAP tests
A couple of TAP tests make use of wal_level=logical for nodes that donot need to do any kind of logical decoding operations, likesubscription nodes on which changes are only applied. This can beconfusing when reading these tests as setup examples, so let's removethis configuration where not required (contrary to two-way logicalreplication and similar more complex cases). This simplifies the testsa bit, making them slightly cheaper with less WAL generated overall.Author: Hayato KurodaDiscussion:https://postgr.es/m/TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com
1 parentafd1277 commitdcd4454

32 files changed

+34
-38
lines changed

‎src/test/recovery/t/035_standby_logical_decoding.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ sub check_for_invalidation
293293
#######################
294294
# Initialize subscriber node
295295
#######################
296-
$node_subscriber->init(allows_streaming=>'logical');
296+
$node_subscriber->init;
297297
$node_subscriber->start;
298298

299299
my%psql_subscriber = (

‎src/test/recovery/t/038_save_logical_slots_shutdown.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ sub compare_confirmed_flush
5353

5454
# Create subscriber node
5555
my$node_subscriber = PostgreSQL::Test::Cluster->new('sub');
56-
$node_subscriber->init(allows_streaming=>'logical');
56+
$node_subscriber->init;
5757
$node_subscriber->start;
5858

5959
# Create tables

‎src/test/subscription/t/001_rep_changes.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Create some preexisting content on publisher

‎src/test/subscription/t/002_types.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# Create subscriber node
1818
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
19-
$node_subscriber->init(allows_streaming=>'logical');
19+
$node_subscriber->init;
2020
$node_subscriber->start;
2121

2222
# Create some preexisting content on publisher

‎src/test/subscription/t/003_constraints.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Setup structure on publisher

‎src/test/subscription/t/004_sync.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->append_conf('postgresql.conf',
2020
"wal_retrieve_retry_interval = 1ms");
2121
$node_subscriber->start;

‎src/test/subscription/t/005_encoding.pl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515
$node_publisher->start;
1616

1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(
19-
allows_streaming=>'logical',
20-
extra=> ['--locale=C','--encoding=LATIN1' ]);
18+
$node_subscriber->init(extra=> ['--locale=C','--encoding=LATIN1' ]);
2119
$node_subscriber->start;
2220

2321
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/006_rewrite.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
$node_publisher->start;
1414

1515
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
16-
$node_subscriber->init(allows_streaming=>'logical');
16+
$node_subscriber->init;
1717
$node_subscriber->start;
1818

1919
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/007_ddl.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
$node_publisher->start;
1414

1515
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
16-
$node_subscriber->init(allows_streaming=>'logical');
16+
$node_subscriber->init;
1717
$node_subscriber->start;
1818

1919
my$ddl ="CREATE TABLE test1 (a int, b text);";

‎src/test/subscription/t/008_diff_schema.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Create some preexisting content on publisher

‎src/test/subscription/t/009_matviews.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
$node_publisher->start;
1414

1515
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
16-
$node_subscriber->init(allows_streaming=>'logical');
16+
$node_subscriber->init;
1717
$node_subscriber->start;
1818

1919
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/010_truncate.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
$node_publisher->start;
1616

1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->append_conf('postgresql.conf',
2020
qq(max_logical_replication_workers = 6));
2121
$node_subscriber->start;

‎src/test/subscription/t/011_generated.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
$node_publisher->start;
1616

1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/012_collation.pl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
$node_publisher->start;
2222

2323
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
24-
$node_subscriber->init(
25-
allows_streaming=>'logical',
26-
extra=> ['--locale=C','--encoding=UTF8' ]);
24+
$node_subscriber->init(extra=> ['--locale=C','--encoding=UTF8' ]);
2725
$node_subscriber->start;
2826

2927
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/013_partition.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
$node_publisher->start;
1616

1717
my$node_subscriber1 = PostgreSQL::Test::Cluster->new('subscriber1');
18-
$node_subscriber1->init(allows_streaming=>'logical');
18+
$node_subscriber1->init;
1919
$node_subscriber1->start;
2020

2121
my$node_subscriber2 = PostgreSQL::Test::Cluster->new('subscriber2');
22-
$node_subscriber2->init(allows_streaming=>'logical');
22+
$node_subscriber2->init;
2323
$node_subscriber2->start;
2424

2525
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/014_binary.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# Create and initialize subscriber node
1818
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
19-
$node_subscriber->init(allows_streaming=>'logical');
19+
$node_subscriber->init;
2020
$node_subscriber->start;
2121

2222
# Create tables on both sides of the replication

‎src/test/subscription/t/015_stream.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ sub test_streaming
131131

132132
# Create subscriber node
133133
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
134-
$node_subscriber->init(allows_streaming=>'logical');
134+
$node_subscriber->init;
135135
$node_subscriber->start;
136136

137137
# Create some preexisting content on publisher

‎src/test/subscription/t/016_stream_subxact.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ sub test_streaming
8484

8585
# Create subscriber node
8686
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
87-
$node_subscriber->init(allows_streaming=>'logical');
87+
$node_subscriber->init;
8888
$node_subscriber->start;
8989

9090
# Create some preexisting content on publisher

‎src/test/subscription/t/017_stream_ddl.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
# Create subscriber node
2222
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
23-
$node_subscriber->init(allows_streaming=>'logical');
23+
$node_subscriber->init;
2424
$node_subscriber->start;
2525

2626
# Create some preexisting content on publisher

‎src/test/subscription/t/018_stream_subxact_abort.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ sub test_streaming
135135

136136
# Create subscriber node
137137
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
138-
$node_subscriber->init(allows_streaming=>'logical');
138+
$node_subscriber->init;
139139
$node_subscriber->start;
140140

141141
# Create some preexisting content on publisher

‎src/test/subscription/t/019_stream_subxact_ddl_abort.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
# Create subscriber node
2323
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
24-
$node_subscriber->init(allows_streaming=>'logical');
24+
$node_subscriber->init;
2525
$node_subscriber->start;
2626

2727
# Create some preexisting content on publisher

‎src/test/subscription/t/020_messages.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# Create subscriber node
1818
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
19-
$node_subscriber->init(allows_streaming=>'logical');
19+
$node_subscriber->init;
2020
$node_subscriber->start;
2121

2222
# Create some preexisting content on publisher

‎src/test/subscription/t/021_twophase.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
# Create subscriber node
2323
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
24-
$node_subscriber->init(allows_streaming=>'logical');
24+
$node_subscriber->init;
2525
$node_subscriber->append_conf('postgresql.conf',
2626
qq(max_prepared_transactions = 10));
2727
$node_subscriber->start;

‎src/test/subscription/t/022_twophase_cascade.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
$node_B->start;
4040
# node_C
4141
my$node_C = PostgreSQL::Test::Cluster->new('node_C');
42-
$node_C->init(allows_streaming=>'logical');
42+
$node_C->init;
4343
$node_C->append_conf(
4444
'postgresql.conf',qq(
4545
max_prepared_transactions = 10

‎src/test/subscription/t/023_twophase_stream.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ sub test_streaming
307307

308308
# Create subscriber node
309309
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
310-
$node_subscriber->init(allows_streaming=>'logical');
310+
$node_subscriber->init;
311311
$node_subscriber->append_conf(
312312
'postgresql.conf',qq(
313313
max_prepared_transactions = 10

‎src/test/subscription/t/024_add_drop_pub.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Create table on publisher

‎src/test/subscription/t/025_rep_changes_for_schema.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121
# Test replication with publications created using FOR TABLES IN SCHEMA

‎src/test/subscription/t/026_stats.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# Create subscriber node.
1717
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
18-
$node_subscriber->init(allows_streaming=>'logical');
18+
$node_subscriber->init;
1919
$node_subscriber->start;
2020

2121

‎src/test/subscription/t/028_row_filter.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# create subscriber node
1616
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
17-
$node_subscriber->init(allows_streaming=>'logical');
17+
$node_subscriber->init;
1818
$node_subscriber->start;
1919

2020
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/031_column_list.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# create subscriber node
1616
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
17-
$node_subscriber->init(allows_streaming=>'logical');
17+
$node_subscriber->init;
1818
$node_subscriber->append_conf('postgresql.conf',
1919
qq(max_logical_replication_workers = 6));
2020
$node_subscriber->start;

‎src/test/subscription/t/032_subscribe_use_index.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# create subscriber node
1616
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
17-
$node_subscriber->init(allows_streaming=>'logical');
17+
$node_subscriber->init;
1818
$node_subscriber->start;
1919

2020
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';

‎src/test/subscription/t/100_bugs.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
$node_publisher->start;
2525

2626
my$node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
27-
$node_subscriber->init(allows_streaming=>'logical');
27+
$node_subscriber->init;
2828
$node_subscriber->start;
2929

3030
my$publisher_connstr =$node_publisher->connstr .' dbname=postgres';
@@ -175,7 +175,7 @@
175175
$node_pub_sub->start;
176176

177177
my$node_sub = PostgreSQL::Test::Cluster->new('testsubscriber1');
178-
$node_sub->init(allows_streaming=>'logical');
178+
$node_sub->init;
179179
$node_sub->start;
180180

181181
# Create the tables in all nodes.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp