NotificationsYou must be signed in to change notification settings
Fork5k
Star17.9k

Commitd3964cd

committed

Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.

The expression that tried to round the value to the nearest TB couldoverflow, leading to bogus output as reported in bug #5993 from NicolaCossu. This isn't likely to ever happen in the intended usage of thefunction (if it could, we'd be needing to use a wider datatype instead);but it's not hard to give the expected output, so let's do so.

1 parent1e28982 commitd3964cdCopy full SHA for d3964cd

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- dbsize.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/dbsize.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -405,9 +405,15 @@ pg_size_pretty(PG_FUNCTION_ARGS)`
`405`	`405`	`(size+mult /2) /mult);`
`406`	`406`	`else`
`407`	`407`	`{`
	`408`	`+/* Here we have to worry about avoiding overflow */`
	`409`	`+int64val;`
	`410`	`+`
`408`	`411`	`mult *=1024;`
	`412`	`+val=size /mult;`
	`413`	`+if ((size %mult) >= (mult /2))`
	`414`	`+val++;`
`409`	`415`	`snprintf(VARDATA(result),50,INT64_FORMAT" TB",`
`410`		`-(size+mult /2) /mult);`
	`416`	`+val);`
`411`	`417`	`}`
`412`	`418`	`}`
`413`	`419`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd3964cd

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/dbsize.c`

0 commit comments