NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitd34794f

committed

Ignore recovery_min_apply_delay until recovery has reached consistent state

Previously recovery_min_apply_delay was applied even before recoveryhad reached consistency. This could cause us to wait a long timeunexpectedly for read-only connections to be allowed. It's problematicbecause the standby was useless during that wait time.This patch changes recovery_min_apply_delay so that it's applied oncethe database has reached the consistent state. That is, even if the delayis set, the standby tries to replay WAL records as fast as possible untilit has reached consistency.Author: Michael PaquierReviewed-By: Julien RouhaudReported-By: Greg CloughBackpatch: 9.4, where recovery_min_apply_delay was addedBug: #13770Discussion:http://www.postgresql.org/message-id/20151111155006.2644.84564@wrigleys.postgresql.org

1 parent60690a6 commitd34794fCopy full SHA for d34794f

File tree

2 files changed

-2

lines changed

doc/src/sgml
- recovery-config.sgml
src/backend/access/transam
- xlog.c

2 files changed

-2

lines changed

`‎doc/src/sgml/recovery-config.sgml`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -462,8 +462,9 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows`
`462`	`462`	`are not visible until the corresponding commit record is applied.`
`463`	`463`	`</para>`
`464`	`464`	`<para>`
`465`		`- The delay occurs until the standby is promoted or triggered. After that`
`466`		`- the standby will end recovery without further waiting.`
	`465`	`+ The delay occurs once the database in recovery has reached a consistent`
	`466`	`+ state, until the standby is promoted or triggered. After that the standby`
	`467`	`+ will end recovery without further waiting.`
`467`	`468`	`</para>`
`468`	`469`	`<para>`
`469`	`470`	`This parameter is intended for use with streaming replication deployments;`

`‎src/backend/access/transam/xlog.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5715,6 +5715,10 @@ recoveryApplyDelay(XLogReaderState *record)`
`5715`	`5715`	`if (recovery_min_apply_delay <=0)`
`5716`	`5716`	`return false;`
`5717`	`5717`
	`5718`	`+/* no delay is applied on a database not yet consistent */`
	`5719`	`+if (!reachedConsistency)`
	`5720`	`+return false;`
	`5721`	`+`
`5718`	`5722`	`/*`
`5719`	`5723`	`* Is it a COMMIT record?`
`5720`	`5724`	`*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd34794f

File tree

2 files changed

2 files changed

`‎doc/src/sgml/recovery-config.sgml`

`‎src/backend/access/transam/xlog.c`

0 commit comments