- Notifications
You must be signed in to change notification settings - Fork4.9k
Commitd2a2ce4
committed
Make upgradecheck a no-op in MSVC's vcregress.pl
322becb has changed upgradecheck to use the TAP tests, discardingpg_upgrade's tests in bincheck. However, this is proving to be a badidea for the Windows buildfarm clients that use MSVC when TAP tests aredisabled as this causes a hard failure at the pg_upgrade step.This commit disables upgradecheck, moving the execution of the tests ofpg_upgrade to bincheck, as per an initial suggestion from AndresFreund, so as the buildfarm is able to live happily with those changes.While on it, remove the routine that was used by upgradecheck tocreate databases whose names are generated with a range of ASCIIcharacters as it is not used since322becb. upgradecheck is removedfrom the CI script for Windows, as bincheck takes care of that now.Per report from buildfarm member hamerkop (MSVC 2017 without a TAPsetup).Reviewed-by: Justin PryzbyDiscussion:https://postgr.es/m/YkbnpriYEAagZ2wH@paquier.xyz1 parentd43085d commitd2a2ce4
File tree
3 files changed
+5
-31
lines changed- doc/src/sgml
- src/tools/msvc
3 files changed
+5
-31
lines changedLines changed: 0 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
443 | 443 |
| |
444 | 444 |
| |
445 | 445 |
| |
446 |
| - | |
447 |
| - | |
448 | 446 |
| |
449 | 447 |
| |
450 | 448 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
470 | 470 |
| |
471 | 471 |
| |
472 | 472 |
| |
473 |
| - | |
474 | 473 |
| |
475 | 474 |
| |
476 | 475 |
| |
|
Lines changed: 5 additions & 28 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
106 | 106 |
| |
107 | 107 |
| |
108 | 108 |
| |
109 |
| - | |
| 109 | + | |
110 | 110 |
| |
111 | 111 |
| |
112 | 112 |
| |
| |||
286 | 286 |
| |
287 | 287 |
| |
288 | 288 |
| |
289 |
| - | |
290 |
| - | |
291 |
| - | |
292 | 289 |
| |
293 | 290 |
| |
294 | 291 |
| |
| |||
498 | 495 |
| |
499 | 496 |
| |
500 | 497 |
| |
501 |
| - | |
502 |
| - | |
503 |
| - | |
504 |
| - | |
505 |
| - | |
506 |
| - | |
507 |
| - | |
508 |
| - | |
509 |
| - | |
510 |
| - | |
511 |
| - | |
512 |
| - | |
513 |
| - | |
514 |
| - | |
515 |
| - | |
516 |
| - | |
517 |
| - | |
518 |
| - | |
519 |
| - | |
520 |
| - | |
521 | 498 |
| |
522 | 499 |
| |
523 |
| - | |
524 |
| - | |
525 |
| - | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
526 | 503 |
| |
527 | 504 |
| |
528 | 505 |
| |
| |||
640 | 617 |
| |
641 | 618 |
| |
642 | 619 |
| |
643 |
| - | |
| 620 | + | |
644 | 621 |
| |
645 | 622 |
| |
646 | 623 |
| |
|
0 commit comments
Comments
(0)