NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitd2202a6

committed

Don't elide blank lines when accumulating psql command history.

This can change the meaning of queries, if the blank line happens tooccur in the middle of a quoted literal, as per complaint from Tomas Vondra.Back-patch to all supported branches.

1 parent003fae7 commitd2202a6Copy full SHA for d2202a6

File tree

1 file changed

-2

lines changed

src/bin/psql
- input.c

1 file changed

-2

lines changed

`‎src/bin/psql/input.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,10 +86,10 @@ void`
`86`	`86`	`pg_append_history(constchar*s,PQExpBufferhistory_buf)`
`87`	`87`	`{`
`88`	`88`	`#ifdefUSE_READLINE`
`89`		`-if (useHistory&&s&&s[0])`
	`89`	`+if (useHistory&&s)`
`90`	`90`	`{`
`91`	`91`	`appendPQExpBufferStr(history_buf,s);`
`92`		`-if (s[strlen(s)-1]!='\n')`
	`92`	`+if (!s[0]\|\|s[strlen(s)-1]!='\n')`
`93`	`93`	`appendPQExpBufferChar(history_buf,'\n');`
`94`	`94`	`}`
`95`	`95`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd2202a6

File tree

1 file changed

1 file changed

`‎src/bin/psql/input.c`

0 commit comments