Commitd0c8cf2

committed

Add a caveat to hash_seq_init_with_hash_value() header comment

The typical use-case for hash_seq_init_with_hash_value() is syscachecallback. Add a caveat that the default hash function doesn't match syscachehash function. So, one needs to define a custom hash function.Reported-by: Pavel StehuleDiscussion:https://postgr.es/m/CAFj8pRAXmv6eyYx%3DE_BTfyK%3DO_%2ByOF8sXB%3D0bn9eOBt90EgWRA%40mail.gmail.comReviewed-by: Pavel Stehule

1 parent49dc191 commitd0c8cf2Copy full SHA for d0c8cf2

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1395,6 +1395,11 @@ hash_seq_init(HASH_SEQ_STATUS status, HTAB hashp)`
`1395`	`1395`	`/*`
`1396`	`1396`	`* Same as above but scan by the given hash value.`
`1397`	`1397`	`* See also hash_seq_search().`
	`1398`	`+ *`
	`1399`	`+ * NOTE: the default hash function doesn't match syscache hash function.`
	`1400`	`+ * Thus, if you're going to use this function in syscache callback, make sure`
	`1401`	`+ * you're using custom hash function. See relatt_cache_syshash()`
	`1402`	`+ * for example.`
`1398`	`1403`	`*/`
`1399`	`1404`	`void`
`1400`	`1405`	`hash_seq_init_with_hash_value(HASH_SEQ_STATUSstatus,HTABhashp,`

Comments

(0)