Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd0a0499

Browse files
committed
Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.
Commit7102070 fixed a similar bug, butit missed the case of database-wide ANALYZE ("use_own_xacts" mode).Commita07e03f changed consequencesfrom silent discard of a pg_class stats (relpages et al.) update toERROR "tuple to be updated was already modified". Losing a relpagesupdate of an ON COMMIT DELETE ROWS table was negligible, but aCOMMIT-time error isn't negligible. Back-patch to v13 (all supportedversions).Reported-by: Richard Guo <guofenglinux@gmail.comReported-by: Robins Tharakan <tharakan@gmail.com>Discussion:https://postgr.es/m/CAMbWs4-XwMKMKJ_GT=p3_-_=j9rQSEs1FbDFUnW9zHuKPsPNEQ@mail.gmail.comBackpatch-through: 13
1 parent065ce49 commitd0a0499

File tree

4 files changed

+65
-0
lines changed

4 files changed

+65
-0
lines changed

‎src/backend/commands/vacuum.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -642,6 +642,8 @@ vacuum(List *relations, VacuumParams *params, BufferAccessStrategy bstrategy,
642642
if (use_own_xacts)
643643
{
644644
PopActiveSnapshot();
645+
/* standard_ProcessUtility() does CCI if !use_own_xacts */
646+
CommandCounterIncrement();
645647
CommitTransactionCommand();
646648
}
647649
else
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
-- Test maintenance commands that visit every eligible relation. Run as a
2+
-- non-superuser, to skip other users' tables.
3+
CREATE ROLE regress_maintain;
4+
SET ROLE regress_maintain;
5+
-- Test database-wide ANALYZE ("use_own_xacts" mode) setting relhassubclass=f
6+
-- for non-partitioning inheritance, w/ ON COMMIT DELETE ROWS building an
7+
-- empty index.
8+
CREATE TEMP TABLE past_inh_db_other (); -- need 2 tables for "use_own_xacts"
9+
CREATE TEMP TABLE past_inh_db_parent () ON COMMIT DELETE ROWS;
10+
CREATE TEMP TABLE past_inh_db_child () INHERITS (past_inh_db_parent);
11+
CREATE INDEX ON past_inh_db_parent ((1));
12+
ANALYZE past_inh_db_parent;
13+
SELECT reltuples, relhassubclass
14+
FROM pg_class WHERE oid = 'past_inh_db_parent'::regclass;
15+
reltuples | relhassubclass
16+
-----------+----------------
17+
0 | t
18+
(1 row)
19+
20+
DROP TABLE past_inh_db_child;
21+
SET client_min_messages = error; -- hide WARNINGs for other users' tables
22+
ANALYZE;
23+
RESET client_min_messages;
24+
SELECT reltuples, relhassubclass
25+
FROM pg_class WHERE oid = 'past_inh_db_parent'::regclass;
26+
reltuples | relhassubclass
27+
-----------+----------------
28+
0 | f
29+
(1 row)
30+
31+
DROP TABLE past_inh_db_parent, past_inh_db_other;
32+
RESET ROLE;
33+
DROP ROLE regress_maintain;

‎src/test/regress/parallel_schedule

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ test: select_parallel
9191
test: write_parallel
9292
test: vacuum_parallel
9393

94+
# Run this alone, because concurrent DROP TABLE would make non-superuser
95+
# "ANALYZE;" fail with "relation with OID $n does not exist".
96+
test: maintain_every
97+
9498
# no relation related tests can be put in this group
9599
test: publication subscription
96100

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
-- Test maintenance commands that visit every eligible relation. Run as a
2+
-- non-superuser, to skip other users' tables.
3+
4+
CREATE ROLE regress_maintain;
5+
SET ROLE regress_maintain;
6+
7+
-- Test database-wide ANALYZE ("use_own_xacts" mode) setting relhassubclass=f
8+
-- for non-partitioning inheritance, w/ ON COMMIT DELETE ROWS building an
9+
-- empty index.
10+
CREATE TEMP TABLE past_inh_db_other ();-- need 2 tables for "use_own_xacts"
11+
CREATE TEMP TABLE past_inh_db_parent ()ONCOMMITDELETE ROWS;
12+
CREATE TEMP TABLE past_inh_db_child () INHERITS (past_inh_db_parent);
13+
CREATEINDEXON past_inh_db_parent ((1));
14+
ANALYZE past_inh_db_parent;
15+
SELECT reltuples, relhassubclass
16+
FROM pg_classWHEREoid='past_inh_db_parent'::regclass;
17+
DROPTABLE past_inh_db_child;
18+
SET client_min_messages= error;-- hide WARNINGs for other users' tables
19+
ANALYZE;
20+
RESET client_min_messages;
21+
SELECT reltuples, relhassubclass
22+
FROM pg_classWHEREoid='past_inh_db_parent'::regclass;
23+
DROPTABLE past_inh_db_parent, past_inh_db_other;
24+
25+
RESET ROLE;
26+
DROP ROLE regress_maintain;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp