NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitcfe1276

committed

Use standard librart sqrt function in pg_stat_statements

The stddev calculation included a faster but unportable sqrt function.This is not worth the extra effort, and won't work everywhere. If thestandard library function is good enough for the SQL function itshould be good enough here too.

1 parent3a20b0e commitcfe1276Copy full SHA for cfe1276

File tree

1 file changed

-19

lines changed

contrib/pg_stat_statements
- pg_stat_statements.c

1 file changed

-19

lines changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

Lines changed: 2 additions & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@`
`57`	`57`	`*/`
`58`	`58`	`#include"postgres.h"`
`59`	`59`
	`60`	`+#include<math.h>`
`60`	`61`	`#include<sys/stat.h>`
`61`	`62`	`#include<unistd.h>`
`62`	`63`
`@@ -326,7 +327,6 @@ static char generate_normalized_query(pgssJumbleState jstate, const char *quer`
`326`	`327`	`int*query_len_p,intencoding);`
`327`	`328`	`staticvoidfill_in_constant_lengths(pgssJumbleStatejstate,constcharquery);`
`328`	`329`	`staticintcomp_location(constvoida,constvoidb);`
`329`		`-staticinlinedoublesqrtd(constdoublex);`
`330`	`330`
`331`	`331`
`332`	`332`	`/*`
`@@ -1583,7 +1583,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,`
`1583`	`1583`	`*/`
`1584`	`1584`	`if (tmp.calls>1)`
`1585`	`1585`	`values[i++]=`
`1586`		`-Float8GetDatum(sqrtd(tmp.sum_var_time /tmp.calls));`
	`1586`	`+Float8GetDatum(sqrt(tmp.sum_var_time /tmp.calls));`
`1587`	`1587`	`else`
`1588`	`1588`	`values[i++]=Float8GetDatum(0.0);`
`1589`	`1589`	`}`
`@@ -2968,20 +2968,3 @@ comp_location(const void a, const void b)`
`2968`	`2968`	`else`
`2969`	`2969`	`return0;`
`2970`	`2970`	`}`
`2971`		`-`
`2972`		`-/*`
`2973`		`- * fast sqrt algorithm: reference from Fast inverse square root algorithms.`
`2974`		`- */`
`2975`		`-staticinlinedouble`
`2976`		`-sqrtd(constdoublex)`
`2977`		`-{`
`2978`		`-doublex_half=0.5*x;`
`2979`		`-long longinttmp=0x5FE6EB50C7B537AAl- ((long longint)&x >>1);`
`2980`		`-doublex_result=* (double*)&tmp;`
`2981`		`-`
`2982`		`-x_result = (1.5- (x_halfx_result*x_result));`
`2983`		`-/* If retry this calculation, it becomes higher precision at sqrt */`
`2984`		`-x_result = (1.5- (x_halfx_result*x_result));`
`2985`		`-`
`2986`		`-returnx_result*x;`
`2987`		`-}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcfe1276

File tree

1 file changed

1 file changed

`‎contrib/pg_stat_statements/pg_stat_statements.c`

0 commit comments