NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitcfbbc1f

committed

pgbench: Remove dead code

doConnect() never returns connections in state CONNECTION_BAD, sochecking for that is pointless. Remove the code that does.This code has been dead sinceba708ea, 20 years ago.Discussion:https://postgr.es/m/20210126195224.GA20361@alvherre.pgsqlReviewed-by: Tom Lane <tgl@sss.pgh.pa.us>

1 parentf2dc962 commitcfbbc1fCopy full SHA for cfbbc1f

File tree

1 file changed

-8

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-8

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3310,14 +3310,6 @@ main(int argc, char **argv)`
`3310`	`3310`	`if (con==NULL)`
`3311`	`3311`	`exit(1);`
`3312`	`3312`
`3313`		`-if (PQstatus(con)==CONNECTION_BAD)`
`3314`		`-{`
`3315`		`-fprintf(stderr,"connection to database \"%s\" failed\n",`
`3316`		`-PQdb(con) ?PQdb(con) :"");`
`3317`		`-fprintf(stderr,"%s",PQerrorMessage(con));`
`3318`		`-exit(1);`
`3319`		`-}`
`3320`		`-`
`3321`	`3313`	`if (ttype!=3)`
`3322`	`3314`	`{`
`3323`	`3315`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcfbbc1f

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments