- Notifications
You must be signed in to change notification settings - Fork4.9k
Commitcb36f8e
committed
Fix order of -I switches for building pg_regress.o.
We need the -I switch for libpq_srcdir to come before any -I switchesinjected by configure. Otherwise there is a risk of pulling in amismatched version of libpq_fe.h from someplace like/usr/local/include, if the platform has another Postgres versioninstalled there. This evidently accounts for today's buildfarmfailures on "anaconda".In principle the -I switch for src/port/ is at similar hazard, and hasbeen for a very long time. But the only .h files we keep there arepg_config_paths.h and pthread-win32.h, neither of which get installedon Unix-ish systems, so the odds of picking up a conflicting headerseem pretty small. That doubtless accounts for the lack of priorreports.Back-patch to v17 where pg_regress acquired a build dependency onlibpq_fe.h. We could go back further to fix the hazard for src/port/in older branches, but it seems unlikely to be worth troubling over.Reported-by: Nathan Bossart <nathandbossart@gmail.com>Author: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/Z-MhRzoc7t-nPUQG@nathanBackpatch-through: 171 parent3430215 commitcb36f8e
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
0 commit comments
Comments
(0)