NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitcb19cd9

committed

Fix assertion on dereferenced object

Commit27cc7cd accidentally placed the assertion ensuringthat the pointer isn't NULL after it had already been accessed.Fix by moving the pointer dereferencing to after the assertion.Backpatch to all supported branches.Author: Dmitry Koval <d.koval@postgrespro.ru>Reviewed-by: Daniel Gustafsson <daniel@yesql.se>Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/1618848d-cdc7-414b-9c03-08cf4bef4408@postgrespro.ruBackpatch-through: 13

1 parenta37c83d commitcb19cd9Copy full SHA for cb19cd9

File tree

1 file changed

-1

lines changed

src/backend/executor
- execMain.c

1 file changed

-1

lines changed

`‎src/backend/executor/execMain.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2631,13 +2631,15 @@ bool`
`2631`	`2631`	`EvalPlanQualFetchRowMark(EPQStateepqstate,Indexrti,TupleTableSlotslot)`
`2632`	`2632`	`{`
`2633`	`2633`	`ExecAuxRowMark*earm=epqstate->relsubs_rowmark[rti-1];`
`2634`		`-ExecRowMark*erm=earm->rowmark;`
	`2634`	`+ExecRowMark*erm;`
`2635`	`2635`	`Datumdatum;`
`2636`	`2636`	`boolisNull;`
`2637`	`2637`
`2638`	`2638`	`Assert(earm!=NULL);`
`2639`	`2639`	`Assert(epqstate->origslot!=NULL);`
`2640`	`2640`
	`2641`	`+erm=earm->rowmark;`
	`2642`	`+`
`2641`	`2643`	`if (RowMarkRequiresRowShareLock(erm->markType))`
`2642`	`2644`	`elog(ERROR,"EvalPlanQual doesn't support locking rowmarks");`
`2643`	`2645`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcb19cd9

File tree

1 file changed

1 file changed

`‎src/backend/executor/execMain.c`

0 commit comments