NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitca00f19

committed

gistendscan() forgot to free so->giststate.

This oversight led to a massive memory leak --- upwards of 10KB per tuple--- during creation-time verification of an exclusion constraint based on aGIST index. In most other scenarios it'd just be a leak of 10KB that wouldbe recovered at end of query, so not too significant; though perhaps theleak would be noticeable in a situation where a GIST index was being usedin a nestloop inner indexscan. In any case, it's a real leak of longstanding, so patch all supported branches. Per report from Harald Fuchs.

1 parent33e111f commitca00f19Copy full SHA for ca00f19

File tree

1 file changed

-1

lines changed

src/backend/access/gist
- gistscan.c

1 file changed

-1

lines changed

`‎src/backend/access/gist/gistscan.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -226,14 +226,17 @@ gistendscan(PG_FUNCTION_ARGS)`
`226`	`226`	`gistfreestack(so->stack);`
`227`	`227`	`gistfreestack(so->markstk);`
`228`	`228`	`if (so->giststate!=NULL)`
	`229`	`+{`
`229`	`230`	`freeGISTstate(so->giststate);`
	`231`	`+pfree(so->giststate);`
	`232`	`+}`
`230`	`233`	`/* drop pins on buffers -- we aren't holding any locks */`
`231`	`234`	`if (BufferIsValid(so->curbuf))`
`232`	`235`	`ReleaseBuffer(so->curbuf);`
`233`	`236`	`if (BufferIsValid(so->markbuf))`
`234`	`237`	`ReleaseBuffer(so->markbuf);`
`235`	`238`	`MemoryContextDelete(so->tempCxt);`
`236`		`-pfree(scan->opaque);`
	`239`	`+pfree(so);`
`237`	`240`	`}`
`238`	`241`
`239`	`242`	`PG_RETURN_VOID();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitca00f19

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistscan.c`

0 commit comments