NotificationsYou must be signed in to change notification settings
Fork5k
Star17.9k

Commitc462b05

committed

Fix the test 005_char_signedness.

pg_upgrade test 005_char_signedness was leaving files likedelete_old_cluster.sh in the source directory for VPATH and mesonbuilds. The fix is to change the directory to tmp_check before runningthe test.Reported-by: Robert Haas <robertmhaas@gmail.com>Reviewed-by: Robert Haas <robertmhaas@gmail.com>Discussion:http://postgr.es/m/CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com

1 parent17caf66 commitc462b05Copy full SHA for c462b05

File tree

1 file changed

-0

lines changed

src/bin/pg_upgrade/t
- 005_char_signedness.pl

1 file changed

-0

lines changed

`‎src/bin/pg_upgrade/t/005_char_signedness.pl`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,11 @@`
`45`	`45`	`qr/Default char data signedness:\s+unsigned/,`
`46`	`46`	`'updated default char signedness is unsigned in control file');`
`47`	`47`
	`48`	`+# In a VPATH build, we'll be started in the source directory, but we want`
	`49`	`+# to run pg_upgrade in the build directory so that any files generated finish`
	`50`	`+# in it, like delete_old_cluster.{sh,bat}.`
	`51`	`+chdir${PostgreSQL::Test::Utils::tmp_check};`
	`52`	`+`
`48`	`53`	`# Cannot use --set-char-signedness option for upgrading from v18+`
`49`	`54`	`command_checks_all(`
`50`	`55`	`[`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc462b05

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/t/005_char_signedness.pl`

0 commit comments