NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitc18c12c

committed

AdjustUpgrade.pm should zap test_ext_cine, too.

test_extensions' test_ext_cine extension has the same upgrade hazardas test_ext7: the regression test leaves it in an updated statefrom which no downgrade path to default is provided. This causesthe update_extensions.sql script helpfully provided by pg_upgradeto fail. So drop it in cross-version-upgrade testing.Not entirely sure how come I didn't hit this in testing yesterday;possibly I'd built the upgrade reference databases withtestmodules-install-check disabled.Backpatch to v10 where this module was introduced.

1 parentddd89df commitc18c12cCopy full SHA for c18c12c

File tree

1 file changed

-1

lines changed

src/test/perl/PostgreSQL/Test
- AdjustUpgrade.pm

1 file changed

-1

lines changed

`‎src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -88,12 +88,13 @@ sub adjust_database_contents`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`
`91`		`-# avoid versionnumberissues with test_ext7`
	`91`	`+# avoidno-path-to-downgrade-extension-version issues`
`92`	`92`	`if ($dbnames{contrib_regression_test_extensions})`
`93`	`93`	`{`
`94`	`94`	`_add_st(`
`95`	`95`	`$result,`
`96`	`96`	`'contrib_regression_test_extensions',`
	`97`	`+'drop extension if exists test_ext_cine',`
`97`	`98`	`'drop extension if exists test_ext7');`
`98`	`99`	`}`
`99`	`100`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc18c12c

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm`

0 commit comments