NotificationsYou must be signed in to change notification settings
Fork5.3k
Star19.2k

Commitbe78305

committed

Protect against torn pages when deleting GIN list pages.

To-be-deleted list pages contain no useful information, as they are beingdeleted, but we must still protect the writes from being torn by a crashafter a partial write. To do that, re-initialize the pages on WAL replay.Jeff Janes caught this with a test program to test partial writes.Backpatch to all supported versions.

1 parent664ac3d commitbe78305Copy full SHA for be78305

File tree

1 file changed

+13

-14

lines changed

src/backend/access/gin
- ginxlog.c

1 file changed

+13

-14

lines changed

`‎src/backend/access/gin/ginxlog.c‎`

Lines changed: 13 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -650,25 +650,24 @@ ginRedoDeleteListPages(XLogRecPtr lsn, XLogRecord *record)`
`650`	`650`	`PageSetTLI(metapage,ThisTimeLineID);`
`651`	`651`	`MarkBufferDirty(metabuffer);`
`652`	`652`
	`653`	`+/*`
	`654`	`+ * No full-page images are taken of the deleted pages. Instead, they are`
	`655`	`+ * re-initialized as empty, deleted pages.`
	`656`	`+ */`
`653`	`657`	`for (i=0;i<data->ndeleted;i++)`
`654`	`658`	`{`
`655`		`-Bufferbuffer=XLogReadBuffer(data->node,data->toDelete[i], false);`
	`659`	`+Bufferbuffer;`
	`660`	`+Pagepage;`
`656`	`661`
`657`		`-if (BufferIsValid(buffer))`
`658`		`-{`
`659`		`-Pagepage=BufferGetPage(buffer);`
`660`		`-`
`661`		`-if (!XLByteLE(lsn,PageGetLSN(page)))`
`662`		`-{`
`663`		`-GinPageGetOpaque(page)->flags=GIN_DELETED;`
	`662`	`+buffer=XLogReadBuffer(data->node,data->toDelete[i], true);`
	`663`	`+page=BufferGetPage(buffer);`
	`664`	`+GinInitBuffer(buffer,GIN_DELETED);`
`664`	`665`
`665`		`-PageSetLSN(page,lsn);`
`666`		`-PageSetTLI(page,ThisTimeLineID);`
`667`		`-MarkBufferDirty(buffer);`
`668`		`-}`
	`666`	`+PageSetLSN(page,lsn);`
	`667`	`+PageSetTLI(page,ThisTimeLineID);`
	`668`	`+MarkBufferDirty(buffer);`
`669`	`669`
`670`		`-UnlockReleaseBuffer(buffer);`
`671`		`-}`
	`670`	`+UnlockReleaseBuffer(buffer);`
`672`	`671`	`}`
`673`	`672`	`UnlockReleaseBuffer(metabuffer);`
`674`	`673`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbe78305

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginxlog.c‎`

0 commit comments