Commitbdc5d95

committed

Add recursion depth protection to LIKE matching.

Since MatchText() recurses, it could in principle be driven to stackoverflow, although quite a long pattern would be needed.

1 parent20c6277 commitbdc5d95Copy full SHA for bdc5d95

File tree

-0

lines changed

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@`
`21`	`21`
`22`	`22`	`#include"catalog/pg_collation.h"`
`23`	`23`	`#include"mb/pg_wchar.h"`
	`24`	`+#include"miscadmin.h"`
`24`	`25`	`#include"utils/builtins.h"`
`25`	`26`	`#include"utils/pg_locale.h"`
`26`	`27`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,9 @@ MatchText(char t, int tlen, char p, int plen,`
`83`	`83`	`if (plen==1&&*p=='%')`
`84`	`84`	`returnLIKE_TRUE;`
`85`	`85`
	`86`	`+/* Since this function recurses, it could be driven to stack overflow */`
	`87`	`+check_stack_depth();`
	`88`	`+`
`86`	`89`	`/*`
`87`	`90`	`* In this loop, we advance by char when matching wildcards (and thus on`
`88`	`91`	`* recursive entry to this function we are properly char-synced). On other`

Comments

(0)