NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitba9eb29

committed

Fix low-probability memory leak in regex execution.

After an internal failure in shortest() or longest() while pinning down theexact location of a match, find() forgot to free the DFA structure beforereturning. This is pretty unlikely to occur, since we just successfullyran the "search" variant of the DFA; but it could happen, and it wouldresult in a session-lifespan memory leak since this code uses malloc()directly. Problem seems to have been aboriginal in Spencer's library,so back-patch all the way.In passing, correct a thinko in a comment I added awhile back about themeaning of the "ntree" field.I happened across these issues while comparing our code to Tcl's versionof the library.

1 parentf7eeb32 commitba9eb29Copy full SHA for ba9eb29

File tree

1 file changed

-1

lines changed

src/backend/regex
- regexec.c

1 file changed

-1

lines changed

`‎src/backend/regex/regexec.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,11 @@ find(struct vars * v,`
`323`	`323`	`(chr**)NULL,&hitend);`
`324`	`324`	`else`
`325`	`325`	`end=longest(v,d,begin,v->stop,&hitend);`
`326`		`-NOERR();`
	`326`	`+if (ISERR())`
	`327`	`+{`
	`328`	`+freedfa(d);`
	`329`	`+returnv->err;`
	`330`	`+}`
`327`	`331`	`if (hitend&&cold==NULL)`
`328`	`332`	`cold=begin;`
`329`	`333`	`if (end!=NULL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitba9eb29

File tree

1 file changed

1 file changed

`‎src/backend/regex/regexec.c`

0 commit comments