NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitb8c9135

committed

Fix potential platform dependence in gist regression test.

The results of the KNN-search test cases were indeterminate, as they askedthe system to sort pairs of points that are exactly equidistant from thequery reference point. It's a bit surprising that we've seen noplatform-specific failures from this in the buildfarm. Perhaps IEEE-floatmath is well enough standardized that no such failures will ever occur onsupported platforms ... but since this entire regression test has yet to beshipped in any non-alpha release, that seems like an unduly optimisticassumption. Tweak the queries so that the correct output is uniquelydefined.(The other queries in this test are also underdetermined; but it looks likethey are regurgitating index rows in insertion order, so for the momentassume that that behavior is stable enough.)Per Greg Stark's experiments with VAX. Back-patch to 9.5 where this testscript was introduced.

1 parent4022f94 commitb8c9135Copy full SHA for b8c9135

File tree

2 files changed

+12

-12

lines changed

src/test/regress
- expected
  - gist.out
- sql
  - gist.sql

2 files changed

+12

-12

lines changed

`‎src/test/regress/expected/gist.out`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,16 +61,16 @@ select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5));`
`61`	`61`	`-- Also test an index-only knn-search`
`62`	`62`	`explain (costs off)`
`63`	`63`	`select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))`
`64`		`-order by p <-> point(0.2, 0.2);`
	`64`	`+order by p <-> point(0.201, 0.201);`
`65`	`65`	`QUERY PLAN`
`66`	`66`	`--------------------------------------------------------`
`67`	`67`	`Index Only Scan using gist_tbl_point_index on gist_tbl`
`68`	`68`	`Index Cond: (p <@ '(0.5,0.5),(0,0)'::box)`
`69`		`- Order By: (p <-> '(0.2,0.2)'::point)`
	`69`	`+ Order By: (p <-> '(0.201,0.201)'::point)`
`70`	`70`	`(3 rows)`
`71`	`71`
`72`	`72`	`select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))`
`73`		`-order by p <-> point(0.2, 0.2);`
	`73`	`+order by p <-> point(0.201, 0.201);`
`74`	`74`	`p`
`75`	`75`	`-------------`
`76`	`76`	`(0.2,0.2)`
`@@ -80,32 +80,32 @@ order by p <-> point(0.2, 0.2);`
`80`	`80`	`(0.1,0.1)`
`81`	`81`	`(0.35,0.35)`
`82`	`82`	`(0.05,0.05)`
`83`		`- (0,0)`
`84`	`83`	`(0.4,0.4)`
	`84`	`+ (0,0)`
`85`	`85`	`(0.45,0.45)`
`86`	`86`	`(0.5,0.5)`
`87`	`87`	`(11 rows)`
`88`	`88`
`89`	`89`	`-- Check commuted case as well`
`90`	`90`	`explain (costs off)`
`91`	`91`	`select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))`
`92`		`-order by point(0.1, 0.1) <-> p;`
	`92`	`+order by point(0.101, 0.101) <-> p;`
`93`	`93`	`QUERY PLAN`
`94`	`94`	`--------------------------------------------------------`
`95`	`95`	`Index Only Scan using gist_tbl_point_index on gist_tbl`
`96`	`96`	`Index Cond: (p <@ '(0.5,0.5),(0,0)'::box)`
`97`		`- Order By: (p <-> '(0.1,0.1)'::point)`
	`97`	`+ Order By: (p <-> '(0.101,0.101)'::point)`
`98`	`98`	`(3 rows)`
`99`	`99`
`100`	`100`	`select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))`
`101`		`-order by point(0.1, 0.1) <-> p;`
	`101`	`+order by point(0.101, 0.101) <-> p;`
`102`	`102`	`p`
`103`	`103`	`-------------`
`104`	`104`	`(0.1,0.1)`
`105`	`105`	`(0.15,0.15)`
`106`	`106`	`(0.05,0.05)`
`107`		`- (0,0)`
`108`	`107`	`(0.2,0.2)`
	`108`	`+ (0,0)`
`109`	`109`	`(0.25,0.25)`
`110`	`110`	`(0.3,0.3)`
`111`	`111`	`(0.35,0.35)`

`‎src/test/regress/sql/gist.sql`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,18 +56,18 @@ select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5));`
`56`	`56`	`-- Also test an index-only knn-search`
`57`	`57`	`explain (costs off)`
`58`	`58`	`select pfrom gist_tblwhere p<@box(point(0,0),point(0.5,0.5))`
`59`		`-order by p<->point(0.2,0.2);`
	`59`	`+order by p<->point(0.201,0.201);`
`60`	`60`
`61`	`61`	`select pfrom gist_tblwhere p<@box(point(0,0),point(0.5,0.5))`
`62`		`-order by p<->point(0.2,0.2);`
	`62`	`+order by p<->point(0.201,0.201);`
`63`	`63`
`64`	`64`	`-- Check commuted case as well`
`65`	`65`	`explain (costs off)`
`66`	`66`	`select pfrom gist_tblwhere p<@box(point(0,0),point(0.5,0.5))`
`67`		`-order bypoint(0.1,0.1)<-> p;`
	`67`	`+order bypoint(0.101,0.101)<-> p;`
`68`	`68`
`69`	`69`	`select pfrom gist_tblwhere p<@box(point(0,0),point(0.5,0.5))`
`70`		`-order bypoint(0.1,0.1)<-> p;`
	`70`	`+order bypoint(0.101,0.101)<-> p;`
`71`	`71`
`72`	`72`	`dropindex gist_tbl_point_index;`
`73`	`73`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb8c9135

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/gist.out`

`‎src/test/regress/sql/gist.sql`

0 commit comments