NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.8k

Commitb6e7780

committed

Fix add_rte_to_flat_rtable() for recent feature additions.

The TABLESAMPLE and row security patches each overlooked this function,though their errors of omission were opposite: RLS failed to zero out thesecurityQuals field, leading to wasteful copying of useless expressiontrees in finished plans, while TABLESAMPLE neglected to add a commentsaying that it intentionally *isn't* deleting the tablesample subtree.There probably should be a similar comment about ctename, too.Back-patch as appropriate.

1 parent49c3000 commitb6e7780Copy full SHA for b6e7780

File tree

1 file changed

-4

lines changed

src/backend/optimizer/plan
- setrefs.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/plan/setrefs.c`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -365,10 +365,10 @@ flatten_rtes_walker(Node node, PlannerGlobal glob)`
`365`	`365`	`*`
`366`	`366`	`* In the flat rangetable, we zero out substructure pointers that are not`
`367`	`367`	`* needed by the executor; this reduces the storage space and copying cost`
`368`		`- * for cached plans. We keep only the alias and eref Alias fields, which`
`369`		`- * are needed by EXPLAIN, and the selectedCols and modifiedCols bitmaps,`
`370`		`- * which are needed for executor-startup permissions checking and for`
`371`		`- *triggerevent checking.`
	`368`	`+ * for cached plans. We keep only thectename,alias and eref Alias fields,`
	`369`	`+ *whichare needed by EXPLAIN, and the selectedCols and modifiedCols bitmaps,`
	`370`	`+ * which are needed for executor-startup permissions checking and for trigger`
	`371`	`+ * event checking.`
`372`	`372`	`*/`
`373`	`373`	`staticvoid`
`374`	`374`	`add_rte_to_flat_rtable(PlannerGlobalglob,RangeTblEntryrte)`
`@@ -388,6 +388,7 @@ add_rte_to_flat_rtable(PlannerGlobal glob, RangeTblEntry rte)`
`388`	`388`	`newrte->ctecoltypes=NIL;`
`389`	`389`	`newrte->ctecoltypmods=NIL;`
`390`	`390`	`newrte->ctecolcollations=NIL;`
	`391`	`+newrte->securityQuals=NIL;`
`391`	`392`
`392`	`393`	`glob->finalrtable=lappend(glob->finalrtable,newrte);`
`393`	`394`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb6e7780

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/setrefs.c`

0 commit comments