NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitb6e3798

committed

Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.

The previous definitions of these GUC variables allowed them to rangeup to INT_MAX, but in point of fact the underlying code would sufferoverflows or other errors with large values. Reduce the maximum valuesto something that won't misbehave. There's no apparent value in workingharder than this, since very large delays aren't sensible for any ofthese. (Note: the risk with archive_timeout is that if we're latechecking the state, the timestamp difference it's being compared tomight overflow. So we need some amount of slop; the choice of INT_MAX/2is arbitrary.)Per followup investigation of bug #7670. Although this isn't a verysignificant fix, might as well back-patch.

1 parentd038966 commitb6e3798Copy full SHA for b6e3798

File tree

2 files changed

-3

lines changed

contrib/auth_delay
- auth_delay.c
src/backend/utils/misc
- guc.c

2 files changed

-3

lines changed

`‎contrib/auth_delay/auth_delay.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ _PG_init(void)`
`59`	`59`	`NULL,`
`60`	`60`	`&auth_delay_milliseconds,`
`61`	`61`	`0,`
`62`		`-0,INT_MAX,`
	`62`	`+0,INT_MAX /1000,`
`63`	`63`	`PGC_SIGHUP,`
`64`	`64`	`GUC_UNIT_MS,`
`65`	`65`	`NULL,`

`‎src/backend/utils/misc/guc.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1466,7 +1466,7 @@ static struct config_int ConfigureNamesInt[] =`
`1466`	`1466`	`GUC_UNIT_S`
`1467`	`1467`	`},`
`1468`	`1468`	`&XLogArchiveTimeout,`
`1469`		`-0,0,INT_MAX,`
	`1469`	`+0,0,INT_MAX /2,`
`1470`	`1470`	`NULL,NULL,NULL`
`1471`	`1471`	`},`
`1472`	`1472`	`{`
`@@ -1476,7 +1476,7 @@ static struct config_int ConfigureNamesInt[] =`
`1476`	`1476`	`GUC_NOT_IN_SAMPLE \|GUC_UNIT_S`
`1477`	`1477`	`},`
`1478`	`1478`	`&PostAuthDelay,`
`1479`		`-0,0,INT_MAX,`
	`1479`	`+0,0,INT_MAX /1000000,`
`1480`	`1480`	`NULL,NULL,NULL`
`1481`	`1481`	`},`
`1482`	`1482`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb6e3798

File tree

2 files changed

2 files changed

`‎contrib/auth_delay/auth_delay.c`

`‎src/backend/utils/misc/guc.c`

0 commit comments