NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commitb136db0

committed

Fix planner's failure to identify multiple hashable ScalarArrayOpExprs

50e17ad (v14) and29f45e2 (v15) made it so the planner could identifyIN and NOT IN clauses which have Const lists as right-hand arguments andwhen an appropriate hash function is available for the data types, markthe ScalarArrayOpExpr as hashable so the executor could execute it moreoptimally by building and probing a hash table during expressionevaluation.These commits both worked correctly when there was only a singleScalarArrayOpExpr in the given expression being processed by theplanner, but when there were multiple, only the first was checked and anysubsequent ones were not identified, which resulted in less optimalexpression evaluation during query execution for all but the first foundScalarArrayOpExpr.Backpatch to 14, where50e17ad was introduced.Author: David Geier <geidav.pg@gmail.com>Discussion:https://postgr.es/m/29a76f51-97b0-4c07-87b7-ec8e3b5345c9@gmail.comBackpatch-through: 14

1 parent6c12ae0 commitb136db0Copy full SHA for b136db0

File tree

1 file changed

-2

lines changed

src/backend/optimizer/util
- clauses.c

1 file changed

-2

lines changed

`‎src/backend/optimizer/util/clauses.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2326,7 +2326,7 @@ convert_saop_to_hashed_saop_walker(Node node, void context)`
`2326`	`2326`	`/* Looks good. Fill in the hash functions */`
`2327`	`2327`	`saop->hashfuncid=lefthashfunc;`
`2328`	`2328`	`}`
`2329`		`-returntrue;`
	`2329`	`+returnfalse;`
`2330`	`2330`	`}`
`2331`	`2331`	`}`
`2332`	`2332`	`else/* !saop->useOr */`
`@@ -2364,7 +2364,7 @@ convert_saop_to_hashed_saop_walker(Node node, void context)`
`2364`	`2364`	`*/`
`2365`	`2365`	`saop->negfuncid=get_opcode(negator);`
`2366`	`2366`	`}`
`2367`		`-returntrue;`
	`2367`	`+returnfalse;`
`2368`	`2368`	`}`
`2369`	`2369`	`}`
`2370`	`2370`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb136db0

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/clauses.c‎`

0 commit comments