Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitae42744

Browse files
committed
Fix pgstatindex() to give consistent results for empty indexes.
For an empty index, the pgstatindex() function would compute 0.0/0.0 forits avg_leaf_density and leaf_fragmentation outputs. On machines thatfollow the IEEE float arithmetic standard with any care, that results ina NaN. However, per report from Rushabh Lathia, Microsoft couldn'tmanage to get this right, so you'd get a bizarre error on Windows.Fix by forcing the results to be NaN explicitly, rather than relying onthe division operator to give that or the snprintf function to print itcorrectly. I have some doubts that this is really the most usefuldefinition, but it seems better to remain backward-compatible withthose platforms for which the behavior wasn't completely broken.Back-patch to 8.2, since the code is like that in all current releases.
1 parent6016005 commitae42744

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

‎contrib/pgstattuple/pgstatindex.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,9 +377,17 @@ pgstatindex(PG_FUNCTION_ARGS)
377377
values[j]=palloc(32);
378378
snprintf(values[j++],32,"%d",indexStat.deleted_pages);
379379
values[j]=palloc(32);
380-
snprintf(values[j++],32,"%.2f",100.0- (float)indexStat.free_space / (float)indexStat.max_avail*100.0);
380+
if (indexStat.max_avail>0)
381+
snprintf(values[j++],32,"%.2f",
382+
100.0- (double)indexStat.free_space / (double)indexStat.max_avail*100.0);
383+
else
384+
snprintf(values[j++],32,"NaN");
381385
values[j]=palloc(32);
382-
snprintf(values[j++],32,"%.2f", (float)indexStat.fragments / (float)indexStat.leaf_pages*100.0);
386+
if (indexStat.leaf_pages>0)
387+
snprintf(values[j++],32,"%.2f",
388+
(double)indexStat.fragments / (double)indexStat.leaf_pages*100.0);
389+
else
390+
snprintf(values[j++],32,"NaN");
383391

384392
tuple=BuildTupleFromCStrings(TupleDescGetAttInMetadata(tupleDesc),
385393
values);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp