Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitad46a2a

Browse files
committed
Remove unreachable code in expression evaluation.
The previous code still contained expression evaluation time supportfor CaseExprs without a defresult. But transformCaseExpr() creates adefault expression if necessary.Author: Andres FreundDiscussion:https://postgr.es/m/4834.1490480275@sss.pgh.pa.us
1 parent8acf08c commitad46a2a

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

‎src/backend/executor/execExpr.c

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,20 +1385,12 @@ ExecInitExprRec(Expr *node, PlanState *parent, ExprState *state,
13851385
state->steps[whenstep].d.jump.jumpdone=state->steps_len;
13861386
}
13871387

1388-
if (caseExpr->defresult)
1389-
{
1390-
/* evaluate ELSE expr into CASE's result variables */
1391-
ExecInitExprRec(caseExpr->defresult,parent,state,
1392-
resv,resnull);
1393-
}
1394-
else
1395-
{
1396-
/* default ELSE is to return NULL */
1397-
scratch.opcode=EEOP_CONST;
1398-
scratch.d.constval.value= (Datum)0;
1399-
scratch.d.constval.isnull= true;
1400-
ExprEvalPushStep(state,&scratch);
1401-
}
1388+
/* transformCaseExpr always adds a default */
1389+
Assert(caseExpr->defresult);
1390+
1391+
/* evaluate ELSE expr into CASE's result variables */
1392+
ExecInitExprRec(caseExpr->defresult,parent,state,
1393+
resv,resnull);
14021394

14031395
/* adjust jump targets */
14041396
foreach(lc,adjust_jumps)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp