NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitab6d1cd

committed

Fix typo in relcache's equalPolicy()

The USING policies were not being checked for differences as the samepolicy was being passed in to both sides of the equal(). This couldresult in backends not realizing that a policy had been changed, ifnone of the other attributes had been changed.Fix by passing to equal() the policy1 and policy2 using quals forcomparison.No need to back-patch as this is not yet released. Noticed whiletesting changes to RLS proposed by Dean Rasheed.

1 parent4cb7d67 commitab6d1cdCopy full SHA for ab6d1cd

File tree

1 file changed

-1

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-1

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -887,7 +887,7 @@ equalPolicy(RowSecurityPolicy policy1, RowSecurityPolicy policy2)`
`887`	`887`	`return false;`
`888`	`888`	`}`
`889`	`889`
`890`		`-if (!equal(policy1->qual,policy1->qual))`
	`890`	`+if (!equal(policy1->qual,policy2->qual))`
`891`	`891`	`return false;`
`892`	`892`	`if (!equal(policy1->with_check_qual,policy2->with_check_qual))`
`893`	`893`	`return false;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitab6d1cd

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments