NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commita7496ae

committed

Make GIN's cleanup pending list process interruptable

Cleanup process could be called by ordinary insert/update and could take a lotof time. Add vacuum_delay_point() to make this process interruptable. Undervacuum this call will also throttle a vacuum process to decrease system load,called from insert/update it will not throttle, and that reduces a latency.Backpatch for all supported branches.Jeff Janes <jeff.janes@gmail.com>

1 parentfad42aa commita7496aeCopy full SHA for a7496ae

File tree

1 file changed

-5

lines changed

src/backend/access/gin
- ginfast.c

1 file changed

-5

lines changed

`‎src/backend/access/gin/ginfast.c`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -759,8 +759,7 @@ ginInsertCleanup(Relation index, GinState *ginstate,`
`759`	`759`	`*/`
`760`	`760`	`processPendingPage(&accum,&datums,page,FirstOffsetNumber);`
`761`	`761`
`762`		`-if (vac_delay)`
`763`		`-vacuum_delay_point();`
	`762`	`+vacuum_delay_point();`
`764`	`763`
`765`	`764`	`/*`
`766`	`765`	`* Is it time to flush memory to disk?Flush if we are at the end of`
`@@ -797,8 +796,7 @@ ginInsertCleanup(Relation index, GinState *ginstate,`
`797`	`796`	`while ((list=ginGetEntry(&accum,&attnum,&entry,&nlist))!=NULL)`
`798`	`797`	`{`
`799`	`798`	`ginEntryInsert(index,ginstate,attnum,entry,list,nlist, FALSE);`
`800`		`-if (vac_delay)`
`801`		`-vacuum_delay_point();`
	`799`	`+vacuum_delay_point();`
`802`	`800`	`}`
`803`	`801`
`804`	`802`	`/*`
`@@ -877,7 +875,7 @@ ginInsertCleanup(Relation index, GinState *ginstate,`
`877`	`875`	`/*`
`878`	`876`	`* Read next page in pending list`
`879`	`877`	`*/`
`880`		`-CHECK_FOR_INTERRUPTS();`
	`878`	`+vacuum_delay_point();`
`881`	`879`	`buffer=ReadBuffer(index,blkno);`
`882`	`880`	`LockBuffer(buffer,GIN_SHARE);`
`883`	`881`	`page=BufferGetPage(buffer);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita7496ae

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginfast.c`

0 commit comments