Commita64aacf

committed

Revert "Propagate CTE property flags when copying a CTE list into a rule."

This reverts commited29089 andequivalent back-branch commits. The issue is subtler than I thought,and it's far from new, so just before a release deadline is no timeto be fooling with it. We'll consider what to do at a bit moreleisure.Discussion:https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com

1 parent4384ecc commita64aacfCopy full SHA for a64aacf

File tree

-6

lines changed

-6

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -504,9 +504,6 @@ rewriteRuleAction(Query *parsetree,`
`504`	`504`	`*`
`505`	`505`	`* This could possibly be fixed by using some sort of internally`
`506`	`506`	`* generated ID, instead of names, to link CTE RTEs to their CTEs.`
`507`		`- * However, decompiling the results would be quite confusing; note the`
`508`		`- * merge of hasRecursive flags below, which could change the apparent`
`509`		`- * semantics of such redundantly-named CTEs.`
`510`	`507`	`*/`
`511`	`508`	`foreach(lc,parsetree->cteList)`
`512`	`509`	`{`
`@@ -528,9 +525,6 @@ rewriteRuleAction(Query *parsetree,`
`528`	`525`	`/* OK, it's safe to combine the CTE lists */`
`529`	`526`	`sub_action->cteList=list_concat(sub_action->cteList,`
`530`	`527`	`copyObject(parsetree->cteList));`
`531`		`-/* ... and don't forget about the associated flags */`
`532`		`-sub_action->hasRecursive \|=parsetree->hasRecursive;`
`533`		`-sub_action->hasModifyingCTE \|=parsetree->hasModifyingCTE;`
`534`	`528`	`}`
`535`	`529`
`536`	`530`	`/*`

Comments

(0)