NotificationsYou must be signed in to change notification settings
Fork5.2k
Star19k

Commita0ff56e

committed

Revert "Don't truncate database and user names in startup packets."

This reverts commit562bee0.We received a report from the field about this change in behavior,so it seems best to revert this commit and to add propermultibyte-aware truncation as a follow-up exercise.Fixes bug #18711.Reported-by: Adam RauchReviewed-by: Tom Lane, Bertrand Drouvot, Bruce Momjian, Thomas MunroDiscussion:https://postgr.es/m/18711-7503ee3e449d2c47%40postgresql.orgBackpatch-through: 17

1 parent4766438 commita0ff56eCopy full SHA for a0ff56e

File tree

1 file changed

-0

lines changed

src/backend/tcop
- backend_startup.c

1 file changed

-0

lines changed

`‎src/backend/tcop/backend_startup.c‎`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -830,6 +830,15 @@ ProcessStartupPacket(Port *port, bool ssl_done, bool gss_done)`
`830`	`830`	`if (port->database_name==NULL\|\|port->database_name[0]=='\0')`
`831`	`831`	`port->database_name=pstrdup(port->user_name);`
`832`	`832`
	`833`	`+/*`
	`834`	`+ * Truncate given database and user names to length of a Postgres name.`
	`835`	`+ * This avoids lookup failures when overlength names are given.`
	`836`	`+ */`
	`837`	`+if (strlen(port->database_name) >=NAMEDATALEN)`
	`838`	`+port->database_name[NAMEDATALEN-1]='\0';`
	`839`	`+if (strlen(port->user_name) >=NAMEDATALEN)`
	`840`	`+port->user_name[NAMEDATALEN-1]='\0';`
	`841`	`+`
`833`	`842`	`if (am_walsender)`
`834`	`843`	`MyBackendType=B_WAL_SENDER;`
`835`	`844`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita0ff56e

File tree

1 file changed

1 file changed

`‎src/backend/tcop/backend_startup.c‎`

0 commit comments