NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commita05cf22

committed

Fix incorrect "return NULL" in BumpAllocLarge().

This must be "return MemoryContextAllocationFailure(context, size, flags)"instead. The effect of this oversight is that if we got a mallocfailure right here, the code would act as though MCXT_ALLOC_NO_OOMhad been specified, whether it was or not. That would likely leadto a null-pointer-dereference crash at the unsuspecting call site.Noted while messing with a patch to improve our Valgrind leakdetection support. Back-patch to v17 where this code came in.

1 parent3007fee commita05cf22Copy full SHA for a05cf22

File tree

1 file changed

-1

lines changed

src/backend/utils/mmgr
- bump.c

1 file changed

-1

lines changed

`‎src/backend/utils/mmgr/bump.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ BumpAllocLarge(MemoryContext context, Size size, int flags)`
`316`	`316`
`317`	`317`	`block= (BumpBlock*)malloc(blksize);`
`318`	`318`	`if (block==NULL)`
`319`		`-returnNULL;`
	`319`	`+returnMemoryContextAllocationFailure(context,size,flags);`
`320`	`320`
`321`	`321`	`context->mem_allocated+=blksize;`
`322`	`322`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita05cf22

File tree

1 file changed

1 file changed

`‎src/backend/utils/mmgr/bump.c`

0 commit comments