Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit98ec35b

Browse files
committed
Fix corruption of pg_shdepend when copying deps from template database
Using for a new database a template database with shared dependenciesthat need to be copied over was causing a corruption of pg_shdependbecause of an off-by-one computation error of the index number used forthe values inserted with a slot.Issue introduced bye3931d0. Monitoring the rest of the code, there areno similar mistakes.Reported-by: Sven KlemmAuthor: Aleksander AlekseevReviewed-by: Daniel Gustafsson, Michael PaquierDiscussion:https://postgr.es/m/CAJ7c6TP0AowkUgNL6zcAK-s5HYsVHVBRWfu69FRubPpfwZGM9A@mail.gmail.comBackpatch-through: 14
1 parentf45dc59 commit98ec35b

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

‎src/backend/catalog/pg_shdepend.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -905,13 +905,13 @@ copyTemplateDependencies(Oid templateDbId, Oid newDbId)
905905

906906
shdep= (Form_pg_shdepend)GETSTRUCT(tup);
907907

908-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_dbid]=ObjectIdGetDatum(newDbId);
909-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_classid]=shdep->classid;
910-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_objid]=shdep->objid;
911-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_objsubid]=shdep->objsubid;
912-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_refclassid]=shdep->refclassid;
913-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_refobjid]=shdep->refobjid;
914-
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_deptype]=shdep->deptype;
908+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_dbid-1]=ObjectIdGetDatum(newDbId);
909+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_classid-1]=shdep->classid;
910+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_objid-1]=shdep->objid;
911+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_objsubid-1]=shdep->objsubid;
912+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_refclassid-1]=shdep->refclassid;
913+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_refobjid-1]=shdep->refobjid;
914+
slot[slot_stored_count]->tts_values[Anum_pg_shdepend_deptype-1]=shdep->deptype;
915915

916916
ExecStoreVirtualTuple(slot[slot_stored_count]);
917917
slot_stored_count++;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp