Commit965213d

committed

Use more mundane 'int' type for cancel key lengths in libpq

The documented max length of a cancel key is 256 bytes, so it fits inuint8. It nevertheless seems weird to not just use 'int', like incommit0f1433f for the backend.Discussion:https://www.postgresql.org/message-id/61be9e31-7b7d-49d5-bc11-721800d89d64%40eisentraut.org

1 parent9d710a1 commit965213dCopy full SHA for 965213d

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1532,7 +1532,7 @@ getParameterStatus(PGconn *conn)`
`1532`	`1532`	`staticint`
`1533`	`1533`	`getBackendKeyData(PGconn*conn,intmsgLength)`
`1534`	`1534`	`{`
`1535`		`-uint8cancel_key_len;`
	`1535`	`+intcancel_key_len;`
`1536`	`1536`
`1537`	`1537`	`if (conn->be_cancel_key)`
`1538`	`1538`	`{`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -547,8 +547,8 @@ struct pg_conn`
`547`	`547`
`548`	`548`	`/* Miscellaneous stuff */`
`549`	`549`	`intbe_pid;/* PID of backend --- needed for cancels */`
	`550`	`+intbe_cancel_key_len;`
`550`	`551`	`charbe_cancel_key;/ query cancellation key and its length */`
`551`		`-uint16be_cancel_key_len;`
`552`	`552`	`pgParameterStatuspstatus;/ ParameterStatus data */`
`553`	`553`	`intclient_encoding;/* encoding id */`
`554`	`554`	`boolstd_strings;/* standard_conforming_strings */`

Comments

(0)