Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit926c7fc

Browse files
committed
injection_points: Tweak more permutation in isolation test "basic"
The CI has reported that using a marker to force the output of thedetach step to happen after the wait step was not enough, asisolationtester has managed to report the detach step as waiting beforethe wait step finishes in some runs.src/test/isolation/README tells that there is a more drastic method toenforce the ordering of the output: an empty step positioned just afterthe wait step can force the wait step to complete before the detach stepbegins. This method has been able to pass 10 runs in the CI here, whileHEAD seems to fail 15~20% of the time in the CF bot.Discussion:https://postgr.es/m/Z6WO8FbqK_FHmrzC@paquier.xyz
1 parent428fadb commit926c7fc

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

‎src/test/modules/injection_points/expected/basic.out

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Parsed test spec with 2 sessions
22

3-
starting permutation: wait1 wakeup2 detach2
3+
starting permutation: wait1 wakeup2noop1detach2
44
injection_points_attach
55
-----------------------
66

@@ -19,6 +19,7 @@ injection_points_run
1919

2020
(1 row)
2121

22+
step noop1:
2223
step detach2: SELECT injection_points_detach('injection-points-wait');
2324
injection_points_detach
2425
-----------------------

‎src/test/modules/injection_points/specs/basic.spec

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,17 @@ setup{
2020
SELECTinjection_points_attach('injection-points-wait','wait');
2121
}
2222
stepwait1{SELECTinjection_points_run('injection-points-wait');}
23+
stepnoop1{}
2324

2425
sessions2
2526
stepwakeup2{SELECTinjection_points_wakeup('injection-points-wait');}
2627
stepdetach2{SELECTinjection_points_detach('injection-points-wait');}
2728

2829
# Detach after wait and wakeup. Note that the detach may finish before
2930
# the SQL function doing the wait returns its result. In order to avoid
30-
# any ordering issues,the detach stepreports its result only once the
31-
#wait has completed. This is enforced with a parenthesized marker.
32-
permutationwait1wakeup2detach2(wait1)
31+
# any ordering issues,a no-op stepis added after the wait, so as the
32+
#detach is not launched until the wait has completed.
33+
permutationwait1wakeup2noop1detach2
3334

3435
# Detach before wakeup. s1 waits until wakeup, ignores the detach.
3536
permutationwait1detach2wakeup2

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp