NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit8c68e07

committed

Avoiding:

cc1: warnings being treated as errorsdatum.c: In function `DatumGetSize':datum.c:57: warning: unsigned value >= 0 is always 1gmake[3]: *** [datum.o] Error 1There was: if (byVal) { if (len >= 0 && len <= sizeof(Datum)) {but len has type Size (unsigned int) and so now there is: if (byVal) { if (len <= sizeof(Datum)) { size = len; } else { elog(WARN, "datumGetSize: Error: type=%ld, byVaL with len=%d", (long) type, len); } } else { /* not byValue */

1 parent9ec39eb commit8c68e07Copy full SHA for 8c68e07

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- datum.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/datum.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`*`
`8`	`8`	`* IDENTIFICATION`
`9`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len)`
`54`	`54`	`Sizesize=0;`
`55`	`55`
`56`	`56`	`if (byVal) {`
`57`		`-if (len>=0&&len<=sizeof(Datum)) {`
	`57`	`+if (len <=sizeof(Datum)) {`
`58`	`58`	`size=len;`
`59`	`59`	`}else {`
`60`	`60`	`elog(WARN,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8c68e07

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/datum.c`

0 commit comments