Commit8b97a09

committed

This patch fixes the well-known but unfixed bug that fetchone() always

returns the first result in the DB-API compliant wrapper. It turned outthat the bug was way down in the C code.Gerhard Häring

1 parentc43d241 commit8b97a09Copy full SHA for 8b97a09

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -554,13 +554,13 @@ pgsource_fetch(pgsourceobject * self, PyObject * args)`
`554`	`554`
`555`	`555`	`for (j=0;j<self->num_fields;j++)`
`556`	`556`	`{`
`557`		`-if (PQgetisnull(self->last_result,i,j))`
	`557`	`+if (PQgetisnull(self->last_result,self->current_row,j))`
`558`	`558`	`{`
`559`	`559`	`Py_INCREF(Py_None);`
`560`	`560`	`str=Py_None;`
`561`	`561`	`}`
`562`	`562`	`else`
`563`		`-str=PyString_FromString(PQgetvalue(self->last_result,i,j));`
	`563`	`+str=PyString_FromString(PQgetvalue(self->last_result,self->current_row,j));`
`564`	`564`
`565`	`565`	`PyTuple_SET_ITEM(rowtuple,j,str);`
`566`	`566`	`}`

Comments

(0)