NotificationsYou must be signed in to change notification settings
Fork5k
Star18.1k

Commit8893c3a

committed

Remove XLogCtl->ckptFullXid.

A few code paths set this variable, but its value is never used.Oversight in commit2fc7af5.Reviewed-by: Aleksander Alekseev <aleksander@tigerdata.com>Discussion:https://postgr.es/m/aHFyE1bs9YR93dQ1%40nathan

1 parent84ce258 commit8893c3aCopy full SHA for 8893c3a

File tree

1 file changed

-17

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-17

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 0 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,6 @@ typedef struct XLogCtlData`
`449`	`449`	`/* Protected by info_lck: */`
`450`	`450`	`XLogwrtRqstLogwrtRqst;`
`451`	`451`	`XLogRecPtrRedoRecPtr;/* a recent copy of Insert->RedoRecPtr */`
`452`		`-FullTransactionIdckptFullXid;/* nextXid of latest checkpoint */`
`453`	`452`	`XLogRecPtrasyncXactLSN;/* LSN of newest async commit/abort */`
`454`	`453`	`XLogRecPtrreplicationSlotMinLSN;/* oldest LSN needed by any slot */`
`455`	`454`
`@@ -5744,7 +5743,6 @@ StartupXLOG(void)`
`5744`	`5743`	`SetMultiXactIdLimit(checkPoint.oldestMulti,checkPoint.oldestMultiDB, true);`
`5745`	`5744`	`SetCommitTsLimit(checkPoint.oldestCommitTsXid,`
`5746`	`5745`	`checkPoint.newestCommitTsXid);`
`5747`		`-XLogCtl->ckptFullXid=checkPoint.nextXid;`
`5748`	`5746`
`5749`	`5747`	`/*`
`5750`	`5748`	`* Clear out any old relcache cache files. This is necessary if we do`
`@@ -7437,11 +7435,6 @@ CreateCheckPoint(int flags)`
`7437`	`7435`	`UpdateControlFile();`
`7438`	`7436`	`LWLockRelease(ControlFileLock);`
`7439`	`7437`
`7440`		`-/* Update shared-memory copy of checkpoint XID/epoch */`
`7441`		`-SpinLockAcquire(&XLogCtl->info_lck);`
`7442`		`-XLogCtl->ckptFullXid=checkPoint.nextXid;`
`7443`		`-SpinLockRelease(&XLogCtl->info_lck);`
`7444`		`-`
`7445`	`7438`	`/*`
`7446`	`7439`	`* We are now done with critical updates; no need for system panic if we`
`7447`	`7440`	`* have trouble while fooling with old log segments.`
`@@ -8516,11 +8509,6 @@ xlog_redo(XLogReaderState *record)`
`8516`	`8509`	`ControlFile->checkPointCopy.nextXid=checkPoint.nextXid;`
`8517`	`8510`	`LWLockRelease(ControlFileLock);`
`8518`	`8511`
`8519`		`-/* Update shared-memory copy of checkpoint XID/epoch */`
`8520`		`-SpinLockAcquire(&XLogCtl->info_lck);`
`8521`		`-XLogCtl->ckptFullXid=checkPoint.nextXid;`
`8522`		`-SpinLockRelease(&XLogCtl->info_lck);`
`8523`		`-`
`8524`	`8512`	`/*`
`8525`	`8513`	`* We should've already switched to the new TLI before replaying this`
`8526`	`8514`	`* record.`
`@@ -8577,11 +8565,6 @@ xlog_redo(XLogReaderState *record)`
`8577`	`8565`	`ControlFile->checkPointCopy.nextXid=checkPoint.nextXid;`
`8578`	`8566`	`LWLockRelease(ControlFileLock);`
`8579`	`8567`
`8580`		`-/* Update shared-memory copy of checkpoint XID/epoch */`
`8581`		`-SpinLockAcquire(&XLogCtl->info_lck);`
`8582`		`-XLogCtl->ckptFullXid=checkPoint.nextXid;`
`8583`		`-SpinLockRelease(&XLogCtl->info_lck);`
`8584`		`-`
`8585`	`8568`	`/* TLI should not change in an on-line checkpoint */`
`8586`	`8569`	`(void)GetCurrentReplayRecPtr(&replayTLI);`
`8587`	`8570`	`if (checkPoint.ThisTimeLineID!=replayTLI)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8893c3a

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments