Commit849b070

committed

Add comment to explain why O_EXCL and O_TRUNC can be ignored in

openFlagsToCreateFileFlags() in certain cases.

1 parentd1d3f4d commit849b070Copy full SHA for 849b070

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1996-2007, PostgreSQL Global Development Group`
`8`	`8`	`*`
`9`		`- * $PostgreSQL: pgsql/src/port/open.c,v 1.18 2007/01/05 22:20:02 momjian Exp $`
	`9`	`+ * $PostgreSQL: pgsql/src/port/open.c,v 1.19 2007/02/13 02:06:22 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -25,20 +25,23 @@ openFlagsToCreateFileFlags(int openFlags)`
`25`	`25`	`{`
`26`	`26`	`switch (openFlags& (O_CREAT \|O_TRUNC \|O_EXCL))`
`27`	`27`	`{`
	`28`	`+/* O_EXCL is meaningless without O_CREAT */`
`28`	`29`	`case0:`
`29`	`30`	`caseO_EXCL:`
`30`	`31`	`returnOPEN_EXISTING;`
`31`	`32`
`32`	`33`	`caseO_CREAT:`
`33`	`34`	`returnOPEN_ALWAYS;`
`34`	`35`
	`36`	`+/* O_EXCL is meaningless without O_CREAT */`
`35`	`37`	`caseO_TRUNC:`
`36`	`38`	`caseO_TRUNC \|O_EXCL:`
`37`	`39`	`returnTRUNCATE_EXISTING;`
`38`	`40`
`39`	`41`	`caseO_CREAT \|O_TRUNC:`
`40`	`42`	`returnCREATE_ALWAYS;`
`41`	`43`
	`44`	`+/* O_TRUNC is meaningless with O_CREAT */`
`42`	`45`	`caseO_CREAT \|O_EXCL:`
`43`	`46`	`caseO_CREAT \|O_TRUNC \|O_EXCL:`
`44`	`47`	`returnCREATE_NEW;`

Comments

(0)