NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit7c57449

committed

Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

For no obvious reason, spi_printtup() was coded to enlarge the tuplepointer table by just 256 slots at a time, rather than doubling the size ateach reallocation, as is our usual habit. For very large SPI results, thismakes for O(N^2) time spent in repalloc(), which of course soon comes todominate the runtime. Use the standard doubling approach instead.This is a longstanding performance bug, so back-patch to all activebranches.Neil Conway

1 parente41718f commit7c57449Copy full SHA for 7c57449

File tree

1 file changed

-1

lines changed

src/backend/executor
- spi.c

1 file changed

-1

lines changed

`‎src/backend/executor/spi.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1622,7 +1622,8 @@ spi_printtup(TupleTableSlot slot, DestReceiver self)`
`1622`	`1622`
`1623`	`1623`	`if (tuptable->free==0)`
`1624`	`1624`	`{`
`1625`		`-tuptable->free=256;`
	`1625`	`+/* Double the size of the pointer array */`
	`1626`	`+tuptable->free=tuptable->alloced;`
`1626`	`1627`	`tuptable->alloced+=tuptable->free;`
`1627`	`1628`	`tuptable->vals= (HeapTuple*)repalloc(tuptable->vals,`
`1628`	`1629`	`tuptable->alloced*sizeof(HeapTuple));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c57449

File tree

1 file changed

1 file changed

`‎src/backend/executor/spi.c`

0 commit comments