Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit720de00

Browse files
committed
Fix fractional vacuum_cost_delay.
Commit4753ef3 changed vacuum_delay_point() to use the WaitLatch() API,to fix the problem that vacuum could keep running for a very long timeafter the postmaster died.Unfortunately, that broke commitcaf626b's support for fractionalvacuum_cost_delay, which shipped in PostgreSQL 12. WaitLatch() works inwhole milliseconds.For now, revert the change from commit4753ef3, but add an explicitcheck for postmaster death. That's an extra system call on systemsother than Linux and FreeBSD, but that overhead doesn't matter muchconsidering that we willingly went to sleep and woke up again. (Inlater work, we might add higher resolution timeouts to the latch API sothat we could do this with our standard programming pattern, but thatwouldn't be back-patched.)Back-patch to 14, where commit4753ef3 arrived.Reported-by: Melanie Plageman <melanieplageman@gmail.com>Discussion:https://postgr.es/m/CAAKRu_b-q0hXCBUCAATh0Z4Zi6UkiC0k2DFgoD3nC-r3SkR3tg%40mail.gmail.com
1 parentd41a178 commit720de00

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

‎src/backend/commands/vacuum.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
#include"postmaster/bgworker_internals.h"
5151
#include"storage/bufmgr.h"
5252
#include"storage/lmgr.h"
53+
#include"storage/pmsignal.h"
5354
#include"storage/proc.h"
5455
#include"storage/procarray.h"
5556
#include"utils/acl.h"
@@ -2232,11 +2233,18 @@ vacuum_delay_point(void)
22322233
if (msec>VacuumCostDelay*4)
22332234
msec=VacuumCostDelay*4;
22342235

2235-
(void)WaitLatch(MyLatch,
2236-
WL_LATCH_SET |WL_TIMEOUT |WL_EXIT_ON_PM_DEATH,
2237-
msec,
2238-
WAIT_EVENT_VACUUM_DELAY);
2239-
ResetLatch(MyLatch);
2236+
pgstat_report_wait_start(WAIT_EVENT_VACUUM_DELAY);
2237+
pg_usleep(msec*1000);
2238+
pgstat_report_wait_end();
2239+
2240+
/*
2241+
* We don't want to ignore postmaster death during very long vacuums
2242+
* with vacuum_cost_delay configured. We can't use the usual
2243+
* WaitLatch() approach here because we want microsecond-based sleep
2244+
* durations above.
2245+
*/
2246+
if (IsUnderPostmaster&& !PostmasterIsAlive())
2247+
exit(1);
22402248

22412249
VacuumCostBalance=0;
22422250

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp