- Notifications
You must be signed in to change notification settings - Fork5k
Commit71bfd15
committed
Code review for recent SQL/JSON commits
- At the last minute and for no particularly good reason, I changed the WITHOUT token to be marked especially for lookahead, from the one in WITHOUT TIME to the one in WITHOUT UNIQUE. Study of upcoming patches (where a new WITHOUT ARRAY WRAPPER clause is added) showed me that the former was better, so put it back the way the original patch had it.- update exprTypmod() for JsonConstructorExpr to return the typmod of the RETURNING clause, as a comment there suggested. Perhaps it's possible for this to make a difference with datetime types, but I didn't try to build a test case.- The nodeFuncs.c support code for new nodes was calling walker() directly instead of the WALK() macro as introduced by commit1c27d16. Modernize that. Also add exprLocation() support for a couple of nodes that missed it. Lastly, reorder the code more sensibly.The WITHOUT_LA -> WITHOUT change means that stored rules containingeither WITHOUT TIME ZONE or WITHOUT UNIQUE KEYS would changerepresentation. Therefore, bump catversion.Discussion:https://postgr.es/m/20230329181708.e64g2tpy7jyufqkr@alvherre.pgsql1 parent8a2b1b1 commit71bfd15
File tree
5 files changed
+266
-172
lines changed- src
- backend
- nodes
- parser
- include/catalog
- interfaces/ecpg/preproc
5 files changed
+266
-172
lines changed0 commit comments
Comments
(0)