Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7144cd5

Browse files
committed
Fix pg_dump --clean with partitioned indexes.
We'd try to drop the partitions of a partitioned index separately,which is disallowed by the backend, leading to an error duringrestore. While the error is harmless, it causes problems if youtry to use --single-transaction mode.Fortunately, there seems no need to do a DROP at all, since thepartition will go away silently when we drop either the parent indexor the partition's table. So just make the DROP conditional on notbeing a partition.Reported-by: jian he <jian.universality@gmail.com>Author: jian he <jian.universality@gmail.com>Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/CACJufxF0QSdkjFKF4di-JGWN6CSdQYEAhGPmQJJCdkSZtd=oLg@mail.gmail.comBackpatch-through: 13
1 parent97d6716 commit7144cd5

File tree

1 file changed

+20
-6
lines changed

1 file changed

+20
-6
lines changed

‎src/bin/pg_dump/pg_dump.c

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16381,7 +16381,17 @@ dumpIndex(Archive *fout, const IndxInfo *indxinfo)
1638116381
qindxname);
1638216382
}
1638316383

16384-
appendPQExpBuffer(delq, "DROP INDEX %s;\n", qqindxname);
16384+
/*
16385+
* If this index is a member of a partitioned index, the backend will
16386+
* not allow us to drop it separately, so don't try. It will go away
16387+
* automatically when we drop either the index's table or the
16388+
* partitioned index. (If, in a selective restore with --clean, we
16389+
* drop neither of those, then this index will not be dropped either.
16390+
* But that's fine, and even if you think it's not, the backend won't
16391+
* let us do differently.)
16392+
*/
16393+
if (indxinfo->parentidx == 0)
16394+
appendPQExpBuffer(delq, "DROP INDEX %s;\n", qqindxname);
1638516395

1638616396
if (indxinfo->dobj.dump & DUMP_COMPONENT_DEFINITION)
1638716397
ArchiveEntry(fout, indxinfo->dobj.catId, indxinfo->dobj.dumpId,
@@ -16436,11 +16446,15 @@ dumpIndexAttach(Archive *fout, const IndexAttachInfo *attachinfo)
1643616446
fmtQualifiedDumpable(attachinfo->partitionIdx));
1643716447

1643816448
/*
16439-
* There is no point in creating a drop query as the drop is done by
16440-
* index drop. (If you think to change this, see also
16441-
* _printTocEntry().) Although this object doesn't really have
16442-
* ownership as such, set the owner field anyway to ensure that the
16443-
* command is run by the correct role at restore time.
16449+
* There is no need for a dropStmt since the drop is done implicitly
16450+
* when we drop either the index's table or the partitioned index.
16451+
* Moreover, since there's no ALTER INDEX DETACH PARTITION command,
16452+
* there's no way to do it anyway. (If you think to change this,
16453+
* consider also what to do with --if-exists.)
16454+
*
16455+
* Although this object doesn't really have ownership as such, set the
16456+
* owner field anyway to ensure that the command is run by the correct
16457+
* role at restore time.
1644416458
*/
1644516459
ArchiveEntry(fout, attachinfo->dobj.catId, attachinfo->dobj.dumpId,
1644616460
ARCHIVE_OPTS(.tag = attachinfo->dobj.name,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp