NotificationsYou must be signed in to change notification settings
Fork5.1k
Star18.7k

Commit7072a88

committed

Remove block information from description of some WAL records for GIN

The WAL records XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGEincluded some information about the blocks added to the record.This information is already provided by XLogRecGetBlockRefInfo() withmuch more details about the blocks included in each record, like thecompression information, for example. This commit removes the blockinformation that existed in the record descriptions specific to GIN.Author: Kirill Reshke <reshkekirill@gmail.com>Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>Discussion:https://postgr.es/m/CALdSSPgk=9WRoXhZy5fdk+T1hiau7qbL_vn94w_L1N=gtEdbsg@mail.gmail.com

1 parenta5b5432 commit7072a88Copy full SHA for 7072a88

File tree

1 file changed

-16

lines changed

src/backend/access/rmgrdesc
- gindesc.c

1 file changed

-16

lines changed

`‎src/backend/access/rmgrdesc/gindesc.c‎`

Lines changed: 2 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,14 +99,7 @@ gin_desc(StringInfo buf, XLogReaderState *record)`
`99`	`99`	`appendStringInfo(buf," children: %u/%u",`
`100`	`100`	`leftChildBlkno,rightChildBlkno);`
`101`	`101`	`}`
`102`		`-if (XLogRecHasBlockImage(record,0))`
`103`		`-{`
`104`		`-if (XLogRecBlockImageApply(record,0))`
`105`		`-appendStringInfoString(buf," (full page image)");`
`106`		`-else`
`107`		`-appendStringInfoString(buf," (full page image, for WAL verification)");`
`108`		`-}`
`109`		`-else`
	`102`	`+if (!XLogRecHasBlockImage(record,0))`
`110`	`103`	`{`
`111`	`104`	`char*payload=XLogRecGetBlockData(record,0,NULL);`
`112`	`105`
`@@ -144,14 +137,7 @@ gin_desc(StringInfo buf, XLogReaderState *record)`
`144`	`137`	`break;`
`145`	`138`	`caseXLOG_GIN_VACUUM_DATA_LEAF_PAGE:`
`146`	`139`	`{`
`147`		`-if (XLogRecHasBlockImage(record,0))`
`148`		`-{`
`149`		`-if (XLogRecBlockImageApply(record,0))`
`150`		`-appendStringInfoString(buf," (full page image)");`
`151`		`-else`
`152`		`-appendStringInfoString(buf," (full page image, for WAL verification)");`
`153`		`-}`
`154`		`-else`
	`140`	`+if (!XLogRecHasBlockImage(record,0))`
`155`	`141`	`{`
`156`	`142`	`ginxlogVacuumDataLeafPage*xlrec=`
`157`	`143`	`(ginxlogVacuumDataLeafPage*)XLogRecGetBlockData(record,0,NULL);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7072a88

File tree

1 file changed

1 file changed

`‎src/backend/access/rmgrdesc/gindesc.c‎`

0 commit comments