- Notifications
You must be signed in to change notification settings - Fork4.9k
Commit6f8127b
committed
Revert analyze support for partitioned tables
This reverts the following commits:1b5617e Describe (auto-)analyze behavior for partitioned tables0e69f70 Set pg_class.reltuples for partitioned tables41badea Document ANALYZE storage parameters for partitioned tables0827e8a autovacuum: handle analyze for partitioned tablesThere are efficiency issues in this code when handling databases withlarge numbers of partitions, and it doesn't look like there isn't anytrivial way to handle those. There are some other issues as well. It'snow too late in the cycle for nontrivial fixes, so we'll have to letPostgres 14 users continue to manually deal with ANALYZE theirpartitioned tables, and hopefully we can fix the issues for Postgres 15.I kept [most of]be280cd ("Don't reset relhasindex for partitionedtables on ANALYZE") because while we added it due to0827e8a, it isa good bugfix in its own right, since it affects manual analyze as wellas autovacuum-induced analyze, and there's no reason to revert it.I retained the addition of relkind 'p' to tables included bypg_stat_user_tables, because reverting that would require a catversionbump.Also, in pg14 only, I keep a struct member that was added toPgStat_TabStatEntry to avoid breaking compatibility with existing statfiles.Backpatch to 14.Discussion:https://postgr.es/m/20210722205458.f2bug3z6qzxzpx2s@alap3.anarazel.de1 parent3aafc03 commit6f8127b
File tree
11 files changed
+56
-320
lines changed- doc/src/sgml
- ref
- src
- backend
- access/common
- commands
- postmaster
- include
11 files changed
+56
-320
lines changedLines changed: 0 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
817 | 817 |
| |
818 | 818 |
| |
819 | 819 |
| |
820 |
| - | |
821 |
| - | |
822 |
| - | |
823 |
| - | |
824 |
| - | |
825 |
| - | |
826 | 820 |
| |
827 | 821 |
| |
828 | 822 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1767 | 1767 |
| |
1768 | 1768 |
| |
1769 | 1769 |
| |
1770 |
| - | |
1771 |
| - | |
| 1770 | + | |
1772 | 1771 |
| |
1773 | 1772 |
| |
1774 | 1773 |
| |
|
Lines changed: 11 additions & 29 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
250 | 250 |
| |
251 | 251 |
| |
252 | 252 |
| |
253 |
| - | |
254 |
| - | |
255 |
| - | |
256 |
| - | |
257 |
| - | |
258 |
| - | |
259 |
| - | |
260 |
| - | |
261 |
| - | |
262 |
| - | |
263 |
| - | |
264 |
| - | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
265 | 263 |
| |
266 | 264 |
| |
267 | 265 |
| |
268 |
| - | |
269 |
| - | |
270 |
| - | |
271 |
| - | |
272 |
| - | |
273 |
| - | |
274 |
| - | |
275 |
| - | |
276 |
| - | |
277 |
| - | |
278 |
| - | |
279 |
| - | |
280 |
| - | |
281 |
| - | |
282 |
| - | |
283 |
| - | |
284 |
| - | |
| 266 | + | |
285 | 267 |
| |
286 | 268 |
| |
287 | 269 |
| |
|
Lines changed: 2 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1374 | 1374 |
| |
1375 | 1375 |
| |
1376 | 1376 |
| |
1377 |
| - | |
1378 |
| - | |
| 1377 | + | |
| 1378 | + | |
1379 | 1379 |
| |
1380 | 1380 |
| |
1381 | 1381 |
| |
| |||
1457 | 1457 |
| |
1458 | 1458 |
| |
1459 | 1459 |
| |
1460 |
| - | |
1461 |
| - | |
1462 | 1460 |
| |
1463 | 1461 |
| |
1464 | 1462 |
| |
| |||
1590 | 1588 |
| |
1591 | 1589 |
| |
1592 | 1590 |
| |
1593 |
| - | |
1594 | 1591 |
| |
1595 | 1592 |
| |
1596 | 1593 |
| |
| |||
1606 | 1603 |
| |
1607 | 1604 |
| |
1608 | 1605 |
| |
1609 |
| - | |
1610 | 1606 |
| |
1611 | 1607 |
| |
1612 | 1608 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
922 | 922 |
| |
923 | 923 |
| |
924 | 924 |
| |
925 |
| - | |
926 |
| - | |
927 |
| - | |
928 |
| - | |
| 925 | + | |
| 926 | + | |
929 | 927 |
| |
930 | 928 |
| |
931 | 929 |
| |
|
Lines changed: 8 additions & 7 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
108 | 108 |
| |
109 | 109 |
| |
110 | 110 |
| |
111 |
| - | |
| 111 | + | |
112 | 112 |
| |
113 | 113 |
| |
114 | 114 |
| |
| |||
237 | 237 |
| |
238 | 238 |
| |
239 | 239 |
| |
240 |
| - | |
| 240 | + | |
241 | 241 |
| |
242 | 242 |
| |
243 | 243 |
| |
| |||
411 | 411 |
| |
412 | 412 |
| |
413 | 413 |
| |
414 |
| - | |
| 414 | + | |
415 | 415 |
| |
416 | 416 |
| |
417 | 417 |
| |
| |||
1979 | 1979 |
| |
1980 | 1980 |
| |
1981 | 1981 |
| |
1982 |
| - | |
1983 |
| - | |
| 1982 | + | |
| 1983 | + | |
1984 | 1984 |
| |
1985 |
| - | |
1986 |
| - | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
1987 | 1988 |
| |
1988 | 1989 |
| |
1989 | 1990 |
| |
|
Lines changed: 11 additions & 39 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
626 | 626 |
| |
627 | 627 |
| |
628 | 628 |
| |
629 |
| - | |
630 |
| - | |
| 629 | + | |
| 630 | + | |
631 | 631 |
| |
632 | 632 |
| |
633 | 633 |
| |
| |||
668 | 668 |
| |
669 | 669 |
| |
670 | 670 |
| |
671 |
| - | |
672 |
| - | |
673 |
| - | |
| 671 | + | |
674 | 672 |
| |
675 |
| - | |
676 |
| - | |
677 |
| - | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
678 | 681 |
| |
679 |
| - | |
680 |
| - | |
681 |
| - | |
682 |
| - | |
683 |
| - | |
684 |
| - | |
685 |
| - | |
686 |
| - | |
687 |
| - | |
688 |
| - | |
689 |
| - | |
690 |
| - | |
691 |
| - | |
692 |
| - | |
693 |
| - | |
694 |
| - | |
695 | 682 |
| |
696 | 683 |
| |
697 |
| - | |
698 |
| - | |
699 |
| - | |
700 |
| - | |
701 |
| - | |
702 |
| - | |
703 |
| - | |
704 |
| - | |
705 |
| - | |
706 |
| - | |
707 |
| - | |
708 |
| - | |
709 |
| - | |
710 |
| - | |
711 |
| - | |
712 | 684 |
| |
713 | 685 |
| |
714 | 686 |
| |
|
Lines changed: 1 addition & 46 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
336 | 336 |
| |
337 | 337 |
| |
338 | 338 |
| |
339 |
| - | |
340 | 339 |
| |
341 | 340 |
| |
342 | 341 |
| |
| |||
1740 | 1739 |
| |
1741 | 1740 |
| |
1742 | 1741 |
| |
1743 |
| - | |
1744 | 1742 |
| |
1745 | 1743 |
| |
1746 | 1744 |
| |
| |||
1889 | 1887 |
| |
1890 | 1888 |
| |
1891 | 1889 |
| |
1892 |
| - | |
1893 |
| - | |
1894 |
| - | |
1895 |
| - | |
| 1890 | + | |
1896 | 1891 |
| |
1897 |
| - | |
1898 |
| - | |
1899 | 1892 |
| |
1900 |
| - | |
1901 | 1893 |
| |
1902 | 1894 |
| |
1903 | 1895 |
| |
| |||
2045 | 2037 |
| |
2046 | 2038 |
| |
2047 | 2039 |
| |
2048 |
| - | |
2049 |
| - | |
2050 |
| - | |
2051 | 2040 |
| |
2052 | 2041 |
| |
2053 | 2042 |
| |
| |||
2194 | 2183 |
| |
2195 | 2184 |
| |
2196 | 2185 |
| |
2197 |
| - | |
2198 |
| - | |
2199 |
| - | |
2200 |
| - | |
2201 |
| - | |
2202 |
| - | |
2203 |
| - | |
2204 |
| - | |
2205 |
| - | |
2206 |
| - | |
2207 |
| - | |
2208 |
| - | |
2209 |
| - | |
2210 |
| - | |
2211 |
| - | |
2212 |
| - | |
2213 |
| - | |
2214 |
| - | |
2215 |
| - | |
2216 |
| - | |
2217 |
| - | |
2218 |
| - | |
2219 |
| - | |
2220 |
| - | |
2221 |
| - | |
2222 |
| - | |
2223 |
| - | |
2224 |
| - | |
2225 |
| - | |
2226 |
| - | |
2227 |
| - | |
2228 |
| - | |
2229 |
| - | |
2230 |
| - | |
2231 | 2186 |
| |
2232 | 2187 |
| |
2233 | 2188 |
| |
|
0 commit comments
Comments
(0)