NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit6acddf5

committed

Prevent pg_ctl from being run as root. Since it uses configuration files

owned by postgres, doing "pg_ctl start" as root could allow a privilegeescalation attack, as pointed out by iDEFENSE. Of course the postmaster wouldfail, but we ought to fail a little sooner to protect sysadmins unfamiliarwith Postgres. The chosen fix is to disable root use of pg_ctl in all cases,just to be confident there are no other holes.

1 parent02571d4 commit6acddf5Copy full SHA for 6acddf5

File tree

1 file changed

-1

lines changed

src/bin/pg_ctl
- pg_ctl.sh

1 file changed

-1

lines changed

`‎src/bin/pg_ctl/pg_ctl.sh`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`#`
`9`	`9`	`#`
`10`	`10`	`# IDENTIFICATION`
`11`		`-# $Header: /cvsroot/pgsql/src/bin/pg_ctl/Attic/pg_ctl.sh,v 1.25 2001/09/29 03:09:32 momjian Exp $`
	`11`	`+# $Header: /cvsroot/pgsql/src/bin/pg_ctl/Attic/pg_ctl.sh,v 1.25.2.1 2004/10/22 00:24:39 tgl Exp $`
`12`	`12`	`#`
`13`	`13`	`#-------------------------------------------------------------------------`
`14`	`14`
`@@ -109,6 +109,14 @@ fi`
`109`	`109`
`110`	`110`	`po_path="$PGPATH/postmaster"`
`111`	`111`
	`112`	+if [`$PGPATH/pg_id -u`-eq 0 ]
	`113`	`+then`
	`114`	`+echo"$CMDNAME: cannot be run as root"1>&2`
	`115`	`+echo"Please log in (using, e.g.,\"su\") as the (unprivileged) user that will"1>&2`
	`116`	`+echo"own the server process."1>&2`
	`117`	`+exit 1`
	`118`	`+fi`
	`119`	`+`
`112`	`120`	`wait=`
`113`	`121`	`wait_seconds=60`
`114`	`122`	`logfile=`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6acddf5

File tree

1 file changed

1 file changed

`‎src/bin/pg_ctl/pg_ctl.sh`

0 commit comments