NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit6830cae

committed

Correct StartupSUBTRANS for page wraparound

StartupSUBTRANS() incorrectly handled cases near the max pageid in the subtransdata structure, which in some cases could lead to errors in startup for HotStandby.This patch wraps the pageids correctly, avoiding any such errors.Identified by exhaustive crash testing by Jeff Janes.Jeff Janes

1 parentbec4d0f commit6830caeCopy full SHA for 6830cae

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- subtrans.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/subtrans.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@`
`44`	`44`	`* 0xFFFFFFFF/SUBTRANS_XACTS_PER_PAGE, and segment numbering at`
`45`	`45`	`* 0xFFFFFFFF/SUBTRANS_XACTS_PER_PAGE/SLRU_PAGES_PER_SEGMENT. We need take no`
`46`	`46`	`* explicit notice of that fact in this module, except when comparing segment`
`47`		`- * and page numbers in TruncateSUBTRANS (see SubTransPagePrecedes).`
	`47`	`+ * and page numbers in TruncateSUBTRANS (see SubTransPagePrecedes) and zeroing`
	`48`	`+ * them in StartupSUBTRANS.`
`48`	`49`	`*/`
`49`	`50`
`50`	`51`	`/* We need four bytes per xact */`
`@@ -253,6 +254,9 @@ StartupSUBTRANS(TransactionId oldestActiveXID)`
`253`	`254`	`{`
`254`	`255`	`(void)ZeroSUBTRANSPage(startPage);`
`255`	`256`	`startPage++;`
	`257`	`+/* must account for wraparound */`
	`258`	`+if (startPage>TransactionIdToPage(MaxTransactionId))`
	`259`	`+startPage=0;`
`256`	`260`	`}`
`257`	`261`	`(void)ZeroSUBTRANSPage(startPage);`
`258`	`262`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6830cae

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/subtrans.c`

0 commit comments