NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit59743de

committed

Fix pg_recvlogical for pre-10 versions

Ine170b8c, protection against modified search_path was added. However,PostgreSQL versions prior to 10 does not accept SQL commands over areplication connection, so the protection would generate a syntax error.Since we cannot run SQL commands on it, we are also not vulnerable tothe issue thate170b8c fixes, so we can just skip this command forolder versions.Author: Michael Paquier <michael@paquier.xyz>

1 parent5917297 commit59743deCopy full SHA for 59743de

File tree

1 file changed

-2

lines changed

src/bin/pg_basebackup
- streamutil.c

1 file changed

-2

lines changed

`‎src/bin/pg_basebackup/streamutil.c`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -209,8 +209,13 @@ GetConnection(void)`
`209`	`209`	`if (conn_opts)`
`210`	`210`	`PQconninfoFree(conn_opts);`
`211`	`211`
`212`		`-/* Set always-secure search path, so malicious users can't get control. */`
`213`		`-if (dbname!=NULL)`
	`212`	`+/*`
	`213`	`+ * Set always-secure search path, so malicious users can't get control.`
	`214`	`+ * The capacity to run normal SQL queries was added in PostgreSQL`
	`215`	`+ * 10, so the search path cannot be changed (by us or attackers) on`
	`216`	`+ * earlier versions.`
	`217`	`+ */`
	`218`	`+if (dbname!=NULL&&PQserverVersion(conn) >=100000)`
`214`	`219`	`{`
`215`	`220`	`PGresult*res;`
`216`	`221`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit59743de

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/streamutil.c`

0 commit comments