NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commit56fadbe

committed

Mark correctly initial slot snapshots with MVCC type when built

When building an initial slot snapshot, snapshots are marked withhistoric MVCC snapshots as type with the marker field being set inSnapBuildBuildSnapshot() but not overriden in SnapBuildInitialSnapshot().Existing callers of SnapBuildBuildSnapshot() do not care about the typeof snapshot used, but extensions calling it actually may, as reported.While on it, mark correctly the snapshot type when importing one. Thisis cosmetic as the field is enforced to 0.Author: Antonin HouskaReviewed-by: Álvaro Herrera, Michael PaquierDiscussion:https://postgr.es/m/23215.1527665193@localhostBackpatch-through: 9.4

1 parent90cfa49 commit56fadbeCopy full SHA for 56fadbe

File tree

2 files changed

-0

lines changed

src/backend
- replication/logical
  - snapbuild.c
- utils/time
  - snapmgr.c

2 files changed

-0

lines changed

`‎src/backend/replication/logical/snapbuild.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -616,6 +616,8 @@ SnapBuildInitialSnapshot(SnapBuild *builder)`
`616`	`616`	`TransactionIdAdvance(xid);`
`617`	`617`	`}`
`618`	`618`
	`619`	`+/* adjust remaining snapshot fields as needed */`
	`620`	`+snap->snapshot_type=SNAPSHOT_MVCC;`
`619`	`621`	`snap->xcnt=newxcnt;`
`620`	`622`	`snap->xip=newxip;`
`621`	`623`

`‎src/backend/utils/time/snapmgr.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1509,6 +1509,8 @@ ImportSnapshot(const char *idstr)`
`1509`	`1509`	`src_isolevel=parseIntFromText("iso:",&filebuf,path);`
`1510`	`1510`	`src_readonly=parseIntFromText("ro:",&filebuf,path);`
`1511`	`1511`
	`1512`	`+snapshot.snapshot_type=SNAPSHOT_MVCC;`
	`1513`	`+`
`1512`	`1514`	`snapshot.xmin=parseXidFromText("xmin:",&filebuf,path);`
`1513`	`1515`	`snapshot.xmax=parseXidFromText("xmax:",&filebuf,path);`
`1514`	`1516`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit56fadbe

File tree

2 files changed

2 files changed

`‎src/backend/replication/logical/snapbuild.c`

`‎src/backend/utils/time/snapmgr.c`

0 commit comments