NotificationsYou must be signed in to change notification settings
Fork5.3k
Star19.2k

Commit5424f4d

committed

Don't call simplify_aggref with a NULL PlannerInfo

42473b3 added prosupport infrastructure to allow simplification ofAggrefs during constant-folding. In some cases the context->root that'sgiven to eval_const_expressions_mutator() can be NULL.42473b3 failedto take that into account, which could result in a crash.To fix, add a check and only call simplify_aggref() when the PlannerInfois set.Author: David Rowley <dgrowleyml@gmail.com>Reported-by: Birler, Altan <altan.birler@tum.de>Discussion:https://postgr.es/m/132d4da23b844d5ab9e352d34096eab5@tum.de

1 parentc902bd5 commit5424f4dCopy full SHA for 5424f4d

File tree

1 file changed

-1

lines changed

src/backend/optimizer/util
- clauses.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/util/clauses.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2638,7 +2638,9 @@ eval_const_expressions_mutator(Node *node,`
`2638`	`2638`	`}`
`2639`	`2639`	`caseT_Aggref:`
`2640`	`2640`	`node=ece_generic_processing(node);`
`2641`		`-returnsimplify_aggref((Aggref*)node,context);`
	`2641`	`+if (context->root!=NULL)`
	`2642`	`+returnsimplify_aggref((Aggref*)node,context);`
	`2643`	`+returnnode;`
`2642`	`2644`	`caseT_OpExpr:`
`2643`	`2645`	`{`
`2644`	`2646`	`OpExprexpr= (OpExpr)node;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5424f4d

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/clauses.c‎`

0 commit comments